2020-05-31 09:21:41

by Oded Gabbay

Subject: [PATCH] habanalabs: correctly cast u64 to void*

Use the u64_to_user_ptr(x) kernel macro to correctly cast u64 to void*

Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Oded Gabbay <[email protected]>
---
drivers/misc/habanalabs/command_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/habanalabs/command_submission.c b/drivers/misc/habanalabs/command_submission.c
index 75d8302352e5..f82974a916c3 100644
--- a/drivers/misc/habanalabs/command_submission.c
+++ b/drivers/misc/habanalabs/command_submission.c
@@ -789,7 +789,7 @@ static int cs_ioctl_signal_wait(struct hl_fpriv *hpriv, enum hl_cs_type cs_type,
size_to_copy = chunk->num_signal_seq_arr *
sizeof(*signal_seq_arr);
if (copy_from_user(signal_seq_arr,
- (void __user *) chunk->signal_seq_arr,
+ u64_to_user_ptr(chunk->signal_seq_arr),
size_to_copy)) {
dev_err(hdev->dev,
"Failed to copy signal seq array from user\n");
--
2.17.1

2020-05-31 10:18:44

by Omer Shpigelman

Subject: RE: [PATCH] habanalabs: correctly cast u64 to void*

On Sun, May 31, 2020 at 12:16 PM, Oded Gabbay <[email protected]> wrote:
> Use the u64_to_user_ptr(x) kernel macro to correctly cast u64 to void*
>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Oded Gabbay <[email protected]>

Reviewed-by: Omer Shpigelman <[email protected]>