2019-11-22 10:06:37

by Peng Fan

[permalink] [raw]
Subject: [PATCH V2] clk: imx: clk-imx7ulp: Add missing sentinel of ulp_div_table

From: Peng Fan <[email protected]>

There should be a sentinel of ulp_div_table, otherwise _get_table_div
may access data out of the array.

Fixes: b1260067ac3d ("clk: imx: add imx7ulp clk driver")
Cc: [email protected]
Signed-off-by: Peng Fan <[email protected]>
---

V2:
cc stable mail list

drivers/clk/imx/clk-imx7ulp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx7ulp.c b/drivers/clk/imx/clk-imx7ulp.c
index 3fdf3d494f0a..281191b55b3a 100644
--- a/drivers/clk/imx/clk-imx7ulp.c
+++ b/drivers/clk/imx/clk-imx7ulp.c
@@ -40,6 +40,7 @@ static const struct clk_div_table ulp_div_table[] = {
{ .val = 5, .div = 16, },
{ .val = 6, .div = 32, },
{ .val = 7, .div = 64, },
+ { /* sentinel */ },
};

static const int pcc2_uart_clk_ids[] __initconst = {
--
2.16.4


2019-11-22 12:04:34

by Aisheng Dong

[permalink] [raw]
Subject: RE: [PATCH V2] clk: imx: clk-imx7ulp: Add missing sentinel of ulp_div_table

> From: Peng Fan <[email protected]>
> Sent: Friday, November 22, 2019 6:05 PM
> Subject: [PATCH V2] clk: imx: clk-imx7ulp: Add missing sentinel of ulp_div_table
>
> There should be a sentinel of ulp_div_table, otherwise _get_table_div may
> access data out of the array.
>
> Fixes: b1260067ac3d ("clk: imx: add imx7ulp clk driver")
> Cc: [email protected]
> Signed-off-by: Peng Fan <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aishen