2019-06-12 07:45:58

by Anson Huang

[permalink] [raw]
Subject: [PATCH 2/2] soc: imx8: Use existing of_root directly

From: Anson Huang <[email protected]>

There is common of_root for reference, no need to find it
from DT again, use of_root directly to make driver simple.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/soc/imx/soc-imx8.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
index 86b925a..a632083 100644
--- a/drivers/soc/imx/soc-imx8.c
+++ b/drivers/soc/imx/soc-imx8.c
@@ -100,7 +100,6 @@ static int __init imx8_soc_init(void)
{
struct soc_device_attribute *soc_dev_attr;
struct soc_device *soc_dev;
- struct device_node *root;
const struct of_device_id *id;
u32 soc_rev = 0;
const struct imx8_soc_data *data;
@@ -112,12 +111,11 @@ static int __init imx8_soc_init(void)

soc_dev_attr->family = "Freescale i.MX";

- root = of_find_node_by_path("/");
- ret = of_property_read_string(root, "model", &soc_dev_attr->machine);
+ ret = of_property_read_string(of_root, "model", &soc_dev_attr->machine);
if (ret)
goto free_soc;

- id = of_match_node(imx8_soc_match, root);
+ id = of_match_node(imx8_soc_match, of_root);
if (!id) {
ret = -ENODEV;
goto free_soc;
@@ -145,8 +143,6 @@ static int __init imx8_soc_init(void)
goto free_rev;
}

- of_node_put(root);
-
if (IS_ENABLED(CONFIG_ARM_IMX_CPUFREQ_DT))
platform_device_register_simple("imx-cpufreq-dt", -1, NULL, 0);

@@ -156,7 +152,6 @@ static int __init imx8_soc_init(void)
kfree(soc_dev_attr->revision);
free_soc:
kfree(soc_dev_attr);
- of_node_put(root);
return ret;
}
device_initcall(imx8_soc_init);
--
2.7.4


2019-06-12 07:50:30

by Aisheng Dong

[permalink] [raw]
Subject: RE: [PATCH 2/2] soc: imx8: Use existing of_root directly

> From: [email protected] [mailto:[email protected]]
> Sent: Wednesday, June 12, 2019 11:36 AM
>
> There is common of_root for reference, no need to find it from DT again, use
> of_root directly to make driver simple.
>
> Signed-off-by: Anson Huang <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Dong Aisheng