2019-07-17 09:03:08

by Anson Huang

Subject: [PATCH] mmc: mxs: use devm_platform_ioremap_resource() to simplify code

From: Anson Huang <[email protected]>

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/mmc/host/mxs-mmc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index b334e81..78e7e35 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -571,7 +571,6 @@ static int mxs_mmc_probe(struct platform_device *pdev)
struct device_node *np = pdev->dev.of_node;
struct mxs_mmc_host *host;
struct mmc_host *mmc;
- struct resource *iores;
int ret = 0, irq_err;
struct regulator *reg_vmmc;
struct mxs_ssp *ssp;
@@ -587,8 +586,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
host = mmc_priv(mmc);
ssp = &host->ssp;
ssp->dev = &pdev->dev;
- iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ssp->base = devm_ioremap_resource(&pdev->dev, iores);
+ ssp->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ssp->base)) {
ret = PTR_ERR(ssp->base);
goto out_mmc_free;
--
2.7.4

2019-07-17 10:24:48

by Aisheng Dong

Subject: RE: [PATCH] mmc: mxs: use devm_platform_ioremap_resource() to simplify code

> From: [email protected] <[email protected]>
> Sent: Wednesday, July 17, 2019 4:53 PM
>
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to simplify
> the code.
>
> Signed-off-by: Anson Huang <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

2019-07-22 13:44:53

by Ulf Hansson

Subject: Re: [PATCH] mmc: mxs: use devm_platform_ioremap_resource() to simplify code

On Wed, 17 Jul 2019 at 11:02, <[email protected]> wrote:
>
> From: Anson Huang <[email protected]>
>
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/mxs-mmc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index b334e81..78e7e35 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -571,7 +571,6 @@ static int mxs_mmc_probe(struct platform_device *pdev)
> struct device_node *np = pdev->dev.of_node;
> struct mxs_mmc_host *host;
> struct mmc_host *mmc;
> - struct resource *iores;
> int ret = 0, irq_err;
> struct regulator *reg_vmmc;
> struct mxs_ssp *ssp;
> @@ -587,8 +586,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
> host = mmc_priv(mmc);
> ssp = &host->ssp;
> ssp->dev = &pdev->dev;
> - iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ssp->base = devm_ioremap_resource(&pdev->dev, iores);
> + ssp->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ssp->base)) {
> ret = PTR_ERR(ssp->base);
> goto out_mmc_free;
> --
> 2.7.4
>