2020-06-22 08:38:47

by Zhao Qiang

Subject: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes

From: Xiaowei Bao <[email protected]>

Add the DSPI nodes for ls1028a.

Signed-off-by: Xiaowei Bao <[email protected]>
Signed-off-by: Zhao Qiang <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 85 +++++++++++++++++++++++
1 file changed, 85 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index dd69c5b..e4f00c2 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -107,6 +107,91 @@
};
};

+&dspi0 {
+ bus-num = <0>;
+ status = "okay";
+
+ flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "jedec,spi-nor";
+ spi-cpol;
+ spi-cpha;
+ reg = <0>;
+ spi-max-frequency = <10000000>;
+ };
+
+ flash@1 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "jedec,spi-nor";
+ spi-cpol;
+ spi-cpha;
+ reg = <1>;
+ spi-max-frequency = <10000000>;
+ };
+
+ flash@2 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "jedec,spi-nor";
+ spi-cpol;
+ spi-cpha;
+ reg = <2>;
+ spi-max-frequency = <10000000>;
+ };
+};
+
+&dspi1 {
+ bus-num = <1>;
+ status = "okay";
+
+ flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "jedec,spi-nor";
+ spi-cpol;
+ spi-cpha;
+ reg = <0>;
+ spi-max-frequency = <10000000>;
+ };
+
+ flash@1 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "jedec,spi-nor";
+ spi-cpol;
+ spi-cpha;
+ reg = <1>;
+ spi-max-frequency = <10000000>;
+ };
+
+ flash@2 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "jedec,spi-nor";
+ spi-cpol;
+ spi-cpha;
+ reg = <2>;
+ spi-max-frequency = <10000000>;
+ };
+};
+
+&dspi2 {
+ bus-num = <2>;
+ status = "okay";
+
+ flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "jedec,spi-nor";
+ spi-cpol;
+ spi-cpha;
+ reg = <0>;
+ spi-max-frequency = <10000000>;
+ };
+};
+
&duart0 {
status = "okay";
};
--
2.7.4

2020-06-23 23:15:15

by Leo Li

Subject: RE: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes

> -----Original Message-----
> From: Qiang Zhao <[email protected]>
> Sent: Monday, June 22, 2020 3:29 AM
> To: [email protected]
> Cc: [email protected]; [email protected]; Leo Li
> <[email protected]>; Qiang Zhao <[email protected]>; Xiaowei Bao
> <[email protected]>
> Subject: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes

This patch is actually defining dspi flash nodes for LS1028a-qds board instead of adding dspi nodes for the soc.

>
> From: Xiaowei Bao <[email protected]>
>
> Add the DSPI nodes for ls1028a.
>
> Signed-off-by: Xiaowei Bao <[email protected]>
> Signed-off-by: Zhao Qiang <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 85
> +++++++++++++++++++++++
> 1 file changed, 85 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index dd69c5b..e4f00c2 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -107,6 +107,91 @@
> };
> };
>
> +&dspi0 {
> + bus-num = <0>;
> + status = "okay";
> +
> + flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <0>;
> + spi-max-frequency = <10000000>;
> + };
> +
> + flash@1 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <1>;
> + spi-max-frequency = <10000000>;
> + };
> +
> + flash@2 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <2>;
> + spi-max-frequency = <10000000>;
> + };
> +};
> +
> +&dspi1 {
> + bus-num = <1>;
> + status = "okay";
> +
> + flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;

These probably are not needed when no sub nodes are defined.

> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <0>;
> + spi-max-frequency = <10000000>;
> + };
> +
> + flash@1 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <1>;
> + spi-max-frequency = <10000000>;
> + };
> +
> + flash@2 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <2>;
> + spi-max-frequency = <10000000>;
> + };
> +};
> +
> +&dspi2 {
> + bus-num = <2>;
> + status = "okay";
> +
> + flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + spi-cpol;
> + spi-cpha;
> + reg = <0>;
> + spi-max-frequency = <10000000>;
> + };
> +};
> +
> &duart0 {
> status = "okay";
> };
> --
> 2.7.4

2020-06-24 02:33:00

by Zhao Qiang

Subject: RE: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes

On 2020/6/24, Leo Li <[email protected]> wrote:

> -----Original Message-----
> From: Leo Li <[email protected]>
> Sent: 2020??6??24?? 7:12
> To: Qiang Zhao <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; Qiang Zhao
> <[email protected]>; Xiaowei Bao <[email protected]>
> Subject: RE: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes
>
>
>
> > -----Original Message-----
> > From: Qiang Zhao <[email protected]>
> > Sent: Monday, June 22, 2020 3:29 AM
> > To: [email protected]
> > Cc: [email protected]; [email protected]; Leo Li
> > <[email protected]>; Qiang Zhao <[email protected]>; Xiaowei Bao
> > <[email protected]>
> > Subject: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes
>
> This patch is actually defining dspi flash nodes for LS1028a-qds board instead
> of adding dspi nodes for the soc.

Thank you! Will correct next version.

>
> >
> > From: Xiaowei Bao <[email protected]>
> >
> > Add the DSPI nodes for ls1028a.
> >
> > Signed-off-by: Xiaowei Bao <[email protected]>
> > Signed-off-by: Zhao Qiang <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 85
> > +++++++++++++++++++++++
> > 1 file changed, 85 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > index dd69c5b..e4f00c2 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > @@ -107,6 +107,91 @@
> > };
> > };
> >
> > +&dspi0 {
> > + bus-num = <0>;
> > + status = "okay";
> > +
> > + flash@0 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <0>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +
> > + flash@1 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <1>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +
> > + flash@2 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <2>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +};
> > +
> > +&dspi1 {
> > + bus-num = <1>;
> > + status = "okay";
> > +
> > + flash@0 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
>
> These probably are not needed when no sub nodes are defined.
>
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <0>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +
> > + flash@1 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <1>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +
> > + flash@2 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <2>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +};
> > +
> > +&dspi2 {
> > + bus-num = <2>;
> > + status = "okay";
> > +
> > + flash@0 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <0>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +};
> > +
> > &duart0 {
> > status = "okay";
> > };
> > --
> > 2.7.4

Best Regards
Qiang Zhao