2020-09-21 13:17:13

by Qinglang Miao

Subject: [PATCH -next] enetc: simplify the return expression of enetc_vf_set_mac_addr()

Simplify the return expression.

Signed-off-by: Qinglang Miao <[email protected]>
---
drivers/net/ethernet/freescale/enetc/enetc_vf.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_vf.c b/drivers/net/ethernet/freescale/enetc/enetc_vf.c
index f14576212..7b5c82c7e 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_vf.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_vf.c
@@ -78,16 +78,11 @@ static int enetc_vf_set_mac_addr(struct net_device *ndev, void *addr)
{
struct enetc_ndev_priv *priv = netdev_priv(ndev);
struct sockaddr *saddr = addr;
- int err;

if (!is_valid_ether_addr(saddr->sa_data))
return -EADDRNOTAVAIL;

- err = enetc_msg_vsi_set_primary_mac_addr(priv, saddr);
- if (err)
- return err;
-
- return 0;
+ return enetc_msg_vsi_set_primary_mac_addr(priv, saddr);
}

static int enetc_vf_set_features(struct net_device *ndev,
--
2.23.0

2020-09-21 13:19:47

by Claudiu Manoil

Subject: RE: [PATCH -next] enetc: simplify the return expression of enetc_vf_set_mac_addr()

>-----Original Message-----
>From: Qinglang Miao <[email protected]>
>Sent: Monday, September 21, 2020 4:10 PM
>To: Claudiu Manoil <[email protected]>
>Cc: David S. Miller <[email protected]>; Jakub Kicinski
><[email protected]>; [email protected]; [email protected];
>Qinglang Miao <[email protected]>
>Subject: [PATCH -next] enetc: simplify the return expression of
>enetc_vf_set_mac_addr()
>
>Simplify the return expression.
>
>Signed-off-by: Qinglang Miao <[email protected]>
Reviewed-by: Claudiu Manoil <[email protected]>

2020-09-21 20:51:33

by David Miller

Subject: Re: [PATCH -next] enetc: simplify the return expression of enetc_vf_set_mac_addr()

From: Qinglang Miao <[email protected]>
Date: Mon, 21 Sep 2020 21:10:26 +0800

> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <[email protected]>

Applied.