From: "yinbo.zhu" <[email protected]>
Signed-off-by: yinbo.zhu <[email protected]>
---
arch/arm/boot/dts/ls1021a.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index ffbf3cf..f525297 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -731,6 +731,8 @@
interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
dr_mode = "host";
snps,quirk-frame-length-adjustment = <0x20>;
+ configure-gfladj;
+ dma-coherent;
snps,dis_rxdet_inp3_quirk;
};
--
2.1.0.27.g96db324
Hi,
[email protected] writes:
> From: "yinbo.zhu" <[email protected]>
>
> Signed-off-by: yinbo.zhu <[email protected]>
> ---
> arch/arm/boot/dts/ls1021a.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index ffbf3cf..f525297 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -731,6 +731,8 @@
> interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
> dr_mode = "host";
> snps,quirk-frame-length-adjustment = <0x20>;
> + configure-gfladj;
this binding isn't documented, nor is it used anywhere.
--
balbi
> -----Original Message-----
> From: [email protected] [mailto:linux-devel-
> [email protected]] On Behalf Of [email protected]
> Sent: Friday, August 11, 2017 4:30 AM
> To: [email protected]; Yinbo Zhu <[email protected]>; Rob
> Herring <[email protected]>; Mark Rutland <[email protected]>;
> Russell King <[email protected]>; Felipe Balbi <[email protected]>
> Cc: open list <[email protected]>; Laurent Pinchart
> <[email protected]>; Catalin Marinas
> <[email protected]>; open list <[email protected]>; open list
> <[email protected]>; Doug Ledford <[email protected]>;
> Stefano Stabellini <[email protected]>; Greg Kroah-Hartman
> <[email protected]>; Bart Van Assche
> <[email protected]>; moderated list <linux-arm-
> [email protected]>
> Subject: [linux-devel] [PATCH 1/3] dts: usb3: Add configure-gfladj property to
> USB3 nod
>
> From: "yinbo.zhu" <[email protected]>
>
There is no device tree binding for this property. You need to add the binding first before you add it to the dts. And normally you need to describe why the change is needed in the commit message.
> Signed-off-by: yinbo.zhu <[email protected]>
> ---
> arch/arm/boot/dts/ls1021a.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index ffbf3cf..f525297 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -731,6 +731,8 @@
> interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
> dr_mode = "host";
> snps,quirk-frame-length-adjustment = <0x20>;
> + configure-gfladj;
> + dma-coherent;
This change is not aligned with your patch title.
> snps,dis_rxdet_inp3_quirk;
> };
>
> --
> 2.1.0.27.g96db324
>
> _______________________________________________
> linux-devel mailing list
> [email protected]
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgforge.
> freescale.net%2Fmailman%2Flistinfo%2Flinux-
> devel&data=01%7C01%7Cleoyang.li%40nxp.com%7C015b054c76ad48399ea408
> d4e09de91d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0&sdata=7ioU%2Bb
> QUP4X%2F8%2BFpcQZICVDHugioStScbrHc0XOqaQs%3D&reserved=0
>From: [email protected] [mailto:linux-devel-
>[email protected]] On Behalf Of [email protected]
>Subject: [linux-devel] [PATCH 1/3] dts: usb3: Add configure-gfladj property to USB3
>nod
>
>From: "yinbo.zhu" <[email protected]>
>
>Signed-off-by: yinbo.zhu <[email protected]>
>---
> arch/arm/boot/dts/ls1021a.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index
>ffbf3cf..f525297 100644
>--- a/arch/arm/boot/dts/ls1021a.dtsi
>+++ b/arch/arm/boot/dts/ls1021a.dtsi
>@@ -731,6 +731,8 @@
> interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
> dr_mode = "host";
> snps,quirk-frame-length-adjustment = <0x20>;
>+ configure-gfladj;
I reckon the "configure-gfladj" is replaced with "snps,quirk-frame-length-adjustment"
in open source, which sets fladj reg value.
Please verify.
>+ dma-coherent;
> snps,dis_rxdet_inp3_quirk;
> };
>
>--
>2.1.0.27.g96db324
>
>_______________________________________________
>linux-devel mailing list
>[email protected]
>http://gforge.freescale.net/mailman/listinfo/linux-devel