2018-07-04 07:51:31

by Colin King

Subject: [PATCH] net: fec: remove redundant variable 'inc'

From: Colin Ian King <[email protected]>

Variable 'inc' is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
warning: variable 'inc' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/freescale/fec_ptp.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index 36c2d7d6ee1b..7e892b1cbd3d 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -99,7 +99,6 @@ static int fec_ptp_enable_pps(struct fec_enet_private *fep, uint enable)
{
unsigned long flags;
u32 val, tempval;
- int inc;
struct timespec64 ts;
u64 ns;
val = 0;
@@ -114,7 +113,6 @@ static int fec_ptp_enable_pps(struct fec_enet_private *fep, uint enable)

fep->pps_channel = DEFAULT_PPS_CHANNEL;
fep->reload_period = PPS_OUPUT_RELOAD_PERIOD;
- inc = fep->ptp_inc;

spin_lock_irqsave(&fep->tmreg_lock, flags);

--
2.17.1

2018-07-04 07:59:44

by Andy Duan

Subject: RE: [PATCH] net: fec: remove redundant variable 'inc'

From: Colin King <[email protected]> Sent: 2018年7月4日 15:50
> Variable 'inc' is being assigned but is never used hence it is redundant and
> can be removed.
>
> Cleans up clang warning:
> warning: variable 'inc' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks.

Acked-by: Fugang Duan <[email protected]>

> ---
> drivers/net/ethernet/freescale/fec_ptp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index 36c2d7d6ee1b..7e892b1cbd3d 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -99,7 +99,6 @@ static int fec_ptp_enable_pps(struct
> fec_enet_private *fep, uint enable) {
> unsigned long flags;
> u32 val, tempval;
> - int inc;
> struct timespec64 ts;
> u64 ns;
> val = 0;
> @@ -114,7 +113,6 @@ static int fec_ptp_enable_pps(struct
> fec_enet_private *fep, uint enable)
>
> fep->pps_channel = DEFAULT_PPS_CHANNEL;
> fep->reload_period = PPS_OUPUT_RELOAD_PERIOD;
> - inc = fep->ptp_inc;
>
> spin_lock_irqsave(&fep->tmreg_lock, flags);
>
> --
> 2.17.1

2018-07-04 13:41:45

by David Miller

Subject: Re: [PATCH] net: fec: remove redundant variable 'inc'

From: Colin King <[email protected]>
Date: Wed, 4 Jul 2018 08:49:43 +0100

> From: Colin Ian King <[email protected]>
>
> Variable 'inc' is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'inc' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied.