2017-11-30 10:50:03

by Oleksandr Shamray

[permalink] [raw]
Subject: RE: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver

Thnaks for point

Best Regards,
Oleksandr Shamray

> -----Original Message-----
> From: Philippe Ombredanne [mailto:[email protected]]
> Sent: Thursday, November 30, 2017 10:21 AM
> To: Kun Yi <[email protected]>
> Cc: Oleksandr Shamray <[email protected]>; Greg Kroah-Hartman
> <[email protected]>; [email protected]; system-sw-low-level <system-
> [email protected]>; [email protected]; [email protected];
> Vadim Pasternak <[email protected]>; [email protected];
> OpenBMC Maillist <[email protected]>; LKML <linux-
> [email protected]>; [email protected];
> [email protected]; Jiri Pirko <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]; Mauro Carvalho Chehab
> <[email protected]>; David S. Miller <[email protected]>; linux-arm-
> [email protected]
> Subject: Re: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx
> families JTAG master driver
>
> On Wed, Nov 29, 2017 at 11:51 PM, Kun Yi <[email protected]> wrote:
> > On Tue, Nov 14, 2017 at 8:11 AM, Oleksandr Shamray
> > <[email protected]> wrote:
> []
> >> diff --git a/drivers/jtag/jtag-aspeed.c b/drivers/jtag/jtag-aspeed.c
> >> new file mode 100644 index 0000000..a6e2417
> >> --- /dev/null
> >> +++ b/drivers/jtag/jtag-aspeed.c
> >> @@ -0,0 +1,782 @@
> >> +/*
> >> + * drivers/jtag/aspeed-jtag.c
> >> + *
> >> + * Copyright (c) 2017 Mellanox Technologies. All rights reserved.
> >> + * Copyright (c) 2017 Oleksandr Shamray <[email protected]>
> >> + *
> >> + * Released under the GPLv2 only.
> >> + * SPDX-License-Identifier: GPL-2.0
> >> + */
>
> I think the SPDX id should be on the first line as requested by Linus and
> documented by Thomas (tglx) and Greg (greg-kh). And it should use //
> comments, e.g:
>
> // SPDX-License-Identifier: GPL-2.0
>
> See the threads discussing all these.
>
>
> --
> Cordially
> Philippe Ombredanne