2019-11-10 21:57:11

by Oded Gabbay

Subject: [PATCH 5/6] habanalabs: don't print error when queues are full

If the queues are full and we return -EAGAIN to the user, there is no need
to print an error, as that case isn't an error and the user is expected to
re-submit the work.

Signed-off-by: Oded Gabbay <[email protected]>
---
drivers/misc/habanalabs/command_submission.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/habanalabs/command_submission.c b/drivers/misc/habanalabs/command_submission.c
index 776ddafc47fb..8850f475a413 100644
--- a/drivers/misc/habanalabs/command_submission.c
+++ b/drivers/misc/habanalabs/command_submission.c
@@ -626,9 +626,10 @@ static int _hl_cs_ioctl(struct hl_fpriv *hpriv, void __user *chunks,

rc = hl_hw_queue_schedule_cs(cs);
if (rc) {
- dev_err(hdev->dev,
- "Failed to submit CS %d.%llu to H/W queues, error %d\n",
- cs->ctx->asid, cs->sequence, rc);
+ if (rc != -EAGAIN)
+ dev_err(hdev->dev,
+ "Failed to submit CS %d.%llu to H/W queues, error %d\n",
+ cs->ctx->asid, cs->sequence, rc);
goto free_cs_object;
}

--
2.17.1

2019-11-11 06:06:48

by Omer Shpigelman

Subject: RE: [PATCH 5/6] habanalabs: don't print error when queues are full

On Sun, Nov 10, 2019 at 11:56 PM Oded Gabbay wrote:
> If the queues are full and we return -EAGAIN to the user, there is no need to
> print an error, as that case isn't an error and the user is expected to re-
> submit the work.
>
> Signed-off-by: Oded Gabbay <[email protected]>

Reviewed-by: Omer Shpigelman <[email protected]>