From: Anson Huang <[email protected]>
ARCH_MXC platforms needs system counter as broadcast timer
to support cpuidle, enable it by default.
Signed-off-by: Anson Huang <[email protected]>
---
arch/arm64/Kconfig.platforms | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 4778c77..f5e623f 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -173,6 +173,7 @@ config ARCH_MXC
select PM
select PM_GENERIC_DOMAINS
select SOC_BUS
+ select TIMER_IMX_SYS_CTR
help
This enables support for the ARMv8 based SoCs in the
NXP i.MX family.
--
2.7.4
From: Anson Huang <[email protected]>
Add i.MX8MM system counter node to enable timer-imx-sysctr
broadcast timer driver.
Signed-off-by: Anson Huang <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 232a741..f606efa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -510,6 +510,15 @@
#pwm-cells = <2>;
status = "disabled";
};
+
+ system_counter: timer@306a0000 {
+ compatible = "nxp,sysctr-timer";
+ reg = <0x306a0000 0x30000>;
+ interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MM_CLK_SYS_CTR>;
+ clock-names = "per";
+ };
};
aips3: bus@30800000 {
--
2.7.4
From: Anson Huang <[email protected]>
Add i.MX8MM system counter clock macro definition.
Signed-off-by: Anson Huang <[email protected]>
---
include/dt-bindings/clock/imx8mm-clock.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/dt-bindings/clock/imx8mm-clock.h b/include/dt-bindings/clock/imx8mm-clock.h
index 07e6c68..a8c2124 100644
--- a/include/dt-bindings/clock/imx8mm-clock.h
+++ b/include/dt-bindings/clock/imx8mm-clock.h
@@ -248,6 +248,8 @@
#define IMX8MM_CLK_SNVS_ROOT 228
#define IMX8MM_CLK_GIC 229
-#define IMX8MM_CLK_END 230
+#define IMX8MM_CLK_SYS_CTR 230
+
+#define IMX8MM_CLK_END 231
#endif
--
2.7.4
On 21.06.19 09:07, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> Add i.MX8MM system counter node to enable timer-imx-sysctr
> broadcast timer driver.
>
do we need similar additions to imx8mq? If so, I think these would fit
in here too.
thanks,
martin
Hi, Martin
> -----Original Message-----
> From: Martin Kepplinger <[email protected]>
> Sent: Saturday, June 22, 2019 8:10 PM
> To: Anson Huang <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Leonard Crestez <[email protected]>; Aisheng Dong
> <[email protected]>; Jacky Bai <[email protected]>; Daniel Baluta
> <[email protected]>; Peng Fan <[email protected]>; Abel Vesa
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]
> Cc: dl-linux-imx <[email protected]>
> Subject: Re: [PATCH 4/4] arm64: dts: imx8mm: Add system counter node
>
> On 21.06.19 09:07, [email protected] wrote:
> > From: Anson Huang <[email protected]>
> >
> > Add i.MX8MM system counter node to enable timer-imx-sysctr broadcast
> > timer driver.
> >
>
>
> do we need similar additions to imx8mq? If so, I think these would fit in here
> too.
i.MX8MQ has something different about system counter driver enablement, I did
it in another patch series.
Anson.
>
> thanks,
> martin
On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> ARCH_MXC platforms needs system counter as broadcast timer
> to support cpuidle, enable it by default.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> arch/arm64/Kconfig.platforms | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 4778c77..f5e623f 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -173,6 +173,7 @@ config ARCH_MXC
> select PM
> select PM_GENERIC_DOMAINS
> select SOC_BUS
> + select TIMER_IMX_SYS_CTR
Where is that driver?
Shawn
> help
> This enables support for the ARMv8 based SoCs in the
> NXP i.MX family.
> --
> 2.7.4
>
Hi, Shawn
> -----Original Message-----
> From: Shawn Guo <[email protected]>
> Sent: Monday, June 24, 2019 10:22 AM
> To: Anson Huang <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Leonard Crestez <[email protected]>; Aisheng Dong
> <[email protected]>; Jacky Bai <[email protected]>; Daniel Baluta
> <[email protected]>; Peng Fan <[email protected]>; Abel Vesa
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]; dl-linux-imx <[email protected]>
> Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC
> platforms
>
> On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected] wrote:
> > From: Anson Huang <[email protected]>
> >
> > ARCH_MXC platforms needs system counter as broadcast timer to support
> > cpuidle, enable it by default.
> >
> > Signed-off-by: Anson Huang <[email protected]>
> > ---
> > arch/arm64/Kconfig.platforms | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/Kconfig.platforms
> > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -173,6 +173,7 @@ config ARCH_MXC
> > select PM
> > select PM_GENERIC_DOMAINS
> > select SOC_BUS
> > + select TIMER_IMX_SYS_CTR
>
> Where is that driver?
The driver is drivers/clocksource/timer-imx-sysctr.c, similar function as GPT.
Thanks,
Anson
>
> Shawn
>
> > help
> > This enables support for the ARMv8 based SoCs in the
> > NXP i.MX family.
> > --
> > 2.7.4
> >
On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote:
> On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected] wrote:
> > From: Anson Huang <[email protected]>
> >
> > ARCH_MXC platforms needs system counter as broadcast timer
> > to support cpuidle, enable it by default.
> >
> > Signed-off-by: Anson Huang <[email protected]>
> > ---
> > arch/arm64/Kconfig.platforms | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > index 4778c77..f5e623f 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -173,6 +173,7 @@ config ARCH_MXC
> > select PM
> > select PM_GENERIC_DOMAINS
> > select SOC_BUS
> > + select TIMER_IMX_SYS_CTR
>
> Where is that driver?
Okay, just found it in the mailbox. They seem to be sent in the wrong
order. Really, you should send this series only after the driver lands
on mainline.
Shawn
Hi, Shawn
> -----Original Message-----
> From: Shawn Guo <[email protected]>
> Sent: Monday, June 24, 2019 10:27 AM
> To: Anson Huang <[email protected]>
> Cc: [email protected]; Aisheng Dong <[email protected]>; Peng
> Fan <[email protected]>; [email protected]; Jacky Bai
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; Daniel Baluta <[email protected]>; linux-
> [email protected]; [email protected]; dl-linux-imx <linux-
> [email protected]>; [email protected]; Leonard Crestez
> <[email protected]>; [email protected]; [email protected];
> [email protected]; Abel Vesa <[email protected]>
> Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC
> platforms
>
> On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote:
> > On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected] wrote:
> > > From: Anson Huang <[email protected]>
> > >
> > > ARCH_MXC platforms needs system counter as broadcast timer to
> > > support cpuidle, enable it by default.
> > >
> > > Signed-off-by: Anson Huang <[email protected]>
> > > ---
> > > arch/arm64/Kconfig.platforms | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/Kconfig.platforms
> > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
> > > --- a/arch/arm64/Kconfig.platforms
> > > +++ b/arch/arm64/Kconfig.platforms
> > > @@ -173,6 +173,7 @@ config ARCH_MXC
> > > select PM
> > > select PM_GENERIC_DOMAINS
> > > select SOC_BUS
> > > + select TIMER_IMX_SYS_CTR
> >
> > Where is that driver?
>
> Okay, just found it in the mailbox. They seem to be sent in the wrong order.
> Really, you should send this series only after the driver lands on mainline.
OK, just noticed that mainline does NOT have it, since I did it based on next tree.
I will resend the patch series after the system counter driver landing on mainline.
Thanks,
Anson.
>
> Shawn
On Fri, 21 Jun 2019 15:07:18 +0800, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> Add i.MX8MM system counter clock macro definition.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> include/dt-bindings/clock/imx8mm-clock.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <[email protected]>
On Mon, Jun 24, 2019 at 02:35:10AM +0000, Anson Huang wrote:
> Hi, Shawn
>
> > -----Original Message-----
> > From: Shawn Guo <[email protected]>
> > Sent: Monday, June 24, 2019 10:27 AM
> > To: Anson Huang <[email protected]>
> > Cc: [email protected]; Aisheng Dong <[email protected]>; Peng
> > Fan <[email protected]>; [email protected]; Jacky Bai
> > <[email protected]>; [email protected]; [email protected];
> > [email protected]; [email protected]; linux-
> > [email protected]; Daniel Baluta <[email protected]>; linux-
> > [email protected]; [email protected]; dl-linux-imx <linux-
> > [email protected]>; [email protected]; Leonard Crestez
> > <[email protected]>; [email protected]; [email protected];
> > [email protected]; Abel Vesa <[email protected]>
> > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC
> > platforms
> >
> > On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote:
> > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected] wrote:
> > > > From: Anson Huang <[email protected]>
> > > >
> > > > ARCH_MXC platforms needs system counter as broadcast timer to
> > > > support cpuidle, enable it by default.
> > > >
> > > > Signed-off-by: Anson Huang <[email protected]>
> > > > ---
> > > > arch/arm64/Kconfig.platforms | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/arch/arm64/Kconfig.platforms
> > > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
> > > > --- a/arch/arm64/Kconfig.platforms
> > > > +++ b/arch/arm64/Kconfig.platforms
> > > > @@ -173,6 +173,7 @@ config ARCH_MXC
> > > > select PM
> > > > select PM_GENERIC_DOMAINS
> > > > select SOC_BUS
> > > > + select TIMER_IMX_SYS_CTR
> > >
> > > Where is that driver?
> >
> > Okay, just found it in the mailbox. They seem to be sent in the wrong order.
> > Really, you should send this series only after the driver lands on mainline.
>
> OK, just noticed that mainline does NOT have it, since I did it based on next tree.
> I will resend the patch series after the system counter driver landing on mainline.
I just picked the series up, so no need to resend.
Shawn
Hi, Shawn
> On Mon, Jun 24, 2019 at 02:35:10AM +0000, Anson Huang wrote:
> > Hi, Shawn
> >
> > > -----Original Message-----
> > > From: Shawn Guo <[email protected]>
> > > Sent: Monday, June 24, 2019 10:27 AM
> > > To: Anson Huang <[email protected]>
> > > Cc: [email protected]; Aisheng Dong <[email protected]>;
> Peng
> > > Fan <[email protected]>; [email protected]; Jacky Bai
> > > <[email protected]>; [email protected]; [email protected];
> > > [email protected]; [email protected]; linux-
> > > [email protected]; Daniel Baluta <[email protected]>;
> > > linux- [email protected]; [email protected]; dl-linux-imx <linux-
> > > [email protected]>; [email protected]; Leonard Crestez
> > > <[email protected]>; [email protected]; [email protected];
> > > [email protected]; Abel Vesa <[email protected]>
> > > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for
> > > ARCH_MXC platforms
> > >
> > > On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote:
> > > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected]
> wrote:
> > > > > From: Anson Huang <[email protected]>
> > > > >
> > > > > ARCH_MXC platforms needs system counter as broadcast timer to
> > > > > support cpuidle, enable it by default.
> > > > >
> > > > > Signed-off-by: Anson Huang <[email protected]>
> > > > > ---
> > > > > arch/arm64/Kconfig.platforms | 1 +
> > > > > 1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/arch/arm64/Kconfig.platforms
> > > > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
> > > > > --- a/arch/arm64/Kconfig.platforms
> > > > > +++ b/arch/arm64/Kconfig.platforms
> > > > > @@ -173,6 +173,7 @@ config ARCH_MXC
> > > > > select PM
> > > > > select PM_GENERIC_DOMAINS
> > > > > select SOC_BUS
> > > > > + select TIMER_IMX_SYS_CTR
> > > >
> > > > Where is that driver?
> > >
> > > Okay, just found it in the mailbox. They seem to be sent in the wrong
> order.
> > > Really, you should send this series only after the driver lands on mainline.
> >
> > OK, just noticed that mainline does NOT have it, since I did it based on next
> tree.
> > I will resend the patch series after the system counter driver landing on
> mainline.
>
> I just picked the series up, so no need to resend.
Something changed for this series, the system counter clock related implementation
are changed after some comments from maintainer, so I think you should picked up
below patch series instead, and drop this series,
https://patchwork.kernel.org/patch/11037953/
thanks,
Anson
On Mon, Jul 22, 2019 at 02:15:10AM +0000, Anson Huang wrote:
> Hi, Shawn
>
> > On Mon, Jun 24, 2019 at 02:35:10AM +0000, Anson Huang wrote:
> > > Hi, Shawn
> > >
> > > > -----Original Message-----
> > > > From: Shawn Guo <[email protected]>
> > > > Sent: Monday, June 24, 2019 10:27 AM
> > > > To: Anson Huang <[email protected]>
> > > > Cc: [email protected]; Aisheng Dong <[email protected]>;
> > Peng
> > > > Fan <[email protected]>; [email protected]; Jacky Bai
> > > > <[email protected]>; [email protected]; [email protected];
> > > > [email protected]; [email protected]; linux-
> > > > [email protected]; Daniel Baluta <[email protected]>;
> > > > linux- [email protected]; [email protected]; dl-linux-imx <linux-
> > > > [email protected]>; [email protected]; Leonard Crestez
> > > > <[email protected]>; [email protected]; [email protected];
> > > > [email protected]; Abel Vesa <[email protected]>
> > > > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for
> > > > ARCH_MXC platforms
> > > >
> > > > On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote:
> > > > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected]
> > wrote:
> > > > > > From: Anson Huang <[email protected]>
> > > > > >
> > > > > > ARCH_MXC platforms needs system counter as broadcast timer to
> > > > > > support cpuidle, enable it by default.
> > > > > >
> > > > > > Signed-off-by: Anson Huang <[email protected]>
> > > > > > ---
> > > > > > arch/arm64/Kconfig.platforms | 1 +
> > > > > > 1 file changed, 1 insertion(+)
> > > > > >
> > > > > > diff --git a/arch/arm64/Kconfig.platforms
> > > > > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
> > > > > > --- a/arch/arm64/Kconfig.platforms
> > > > > > +++ b/arch/arm64/Kconfig.platforms
> > > > > > @@ -173,6 +173,7 @@ config ARCH_MXC
> > > > > > select PM
> > > > > > select PM_GENERIC_DOMAINS
> > > > > > select SOC_BUS
> > > > > > + select TIMER_IMX_SYS_CTR
> > > > >
> > > > > Where is that driver?
> > > >
> > > > Okay, just found it in the mailbox. They seem to be sent in the wrong
> > order.
> > > > Really, you should send this series only after the driver lands on mainline.
> > >
> > > OK, just noticed that mainline does NOT have it, since I did it based on next
> > tree.
> > > I will resend the patch series after the system counter driver landing on
> > mainline.
> >
> > I just picked the series up, so no need to resend.
>
> Something changed for this series, the system counter clock related implementation
> are changed after some comments from maintainer, so I think you should picked up
> below patch series instead, and drop this series,
>
> https://patchwork.kernel.org/patch/11037953/
Okay, dropped clk and dts patches. arch/arm64/Kconfig.platforms one is kept.
Shawn