2020-05-15 13:11:46

by Anson Huang

Subject: [PATCH] tty: serial: fsl_lpuart: Use __maybe_unused instead of #if CONFIG_PM_SLEEP

Use __maybe_unused for power management related functions to simplify
the code.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/tty/serial/fsl_lpuart.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 6a9909e..cca485d 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -2662,8 +2662,7 @@ static int lpuart_remove(struct platform_device *pdev)
return 0;
}

-#ifdef CONFIG_PM_SLEEP
-static int lpuart_suspend(struct device *dev)
+static int __maybe_unused lpuart_suspend(struct device *dev)
{
struct lpuart_port *sport = dev_get_drvdata(dev);
unsigned long temp;
@@ -2721,7 +2720,7 @@ static int lpuart_suspend(struct device *dev)
return 0;
}

-static int lpuart_resume(struct device *dev)
+static int __maybe_unused lpuart_resume(struct device *dev)
{
struct lpuart_port *sport = dev_get_drvdata(dev);
bool irq_wake = irqd_is_wakeup_set(irq_get_irq_data(sport->port.irq));
@@ -2752,7 +2751,6 @@ static int lpuart_resume(struct device *dev)

return 0;
}
-#endif

static SIMPLE_DEV_PM_OPS(lpuart_pm_ops, lpuart_suspend, lpuart_resume);

--
2.7.4

2020-05-18 03:49:05

by Aisheng Dong

Subject: RE: [PATCH] tty: serial: fsl_lpuart: Use __maybe_unused instead of #if CONFIG_PM_SLEEP

> From: Anson Huang <[email protected]>
> Sent: Friday, May 15, 2020 8:58 PM
>
> Use __maybe_unused for power management related functions to simplify the
> code.
>
> Signed-off-by: Anson Huang <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

> ---
> drivers/tty/serial/fsl_lpuart.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> 6a9909e..cca485d 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -2662,8 +2662,7 @@ static int lpuart_remove(struct platform_device
> *pdev)
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
> -static int lpuart_suspend(struct device *dev)
> +static int __maybe_unused lpuart_suspend(struct device *dev)
> {
> struct lpuart_port *sport = dev_get_drvdata(dev);
> unsigned long temp;
> @@ -2721,7 +2720,7 @@ static int lpuart_suspend(struct device *dev)
> return 0;
> }
>
> -static int lpuart_resume(struct device *dev)
> +static int __maybe_unused lpuart_resume(struct device *dev)
> {
> struct lpuart_port *sport = dev_get_drvdata(dev);
> bool irq_wake = irqd_is_wakeup_set(irq_get_irq_data(sport->port.irq));
> @@ -2752,7 +2751,6 @@ static int lpuart_resume(struct device *dev)
>
> return 0;
> }
> -#endif
>
> static SIMPLE_DEV_PM_OPS(lpuart_pm_ops, lpuart_suspend, lpuart_resume);
>
> --
> 2.7.4