2020-09-28 09:14:49

by Ran Wang

Subject: [PATCH] arm64: dts: fix endianness of rcpm

From: Biwen Li <[email protected]>

Add little-endian property of rcpm for ls1028a,ls1088a,ls208xa

Signed-off-by: Biwen Li <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 +
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 1 +
arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 +
3 files changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 0efeb8f..651bfe1 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -1012,6 +1012,7 @@
compatible = "fsl,ls1028a-rcpm", "fsl,qoriq-rcpm-2.1+";
reg = <0x0 0x1e34040 0x0 0x1c>;
#fsl,rcpm-wakeup-cells = <7>;
+ little-endian;
};

ftm_alarm0: timer@2800000 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index 169f474..2ef812d 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -787,6 +787,7 @@
compatible = "fsl,ls1088a-rcpm", "fsl,qoriq-rcpm-2.1+";
reg = <0x0 0x1e34040 0x0 0x18>;
#fsl,rcpm-wakeup-cells = <6>;
+ little-endian;
};

ftm_alarm0: timer@2800000 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index 41102da..141b3d2 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -769,6 +769,7 @@
compatible = "fsl,ls208xa-rcpm", "fsl,qoriq-rcpm-2.1+";
reg = <0x0 0x1e34040 0x0 0x18>;
#fsl,rcpm-wakeup-cells = <6>;
+ little-endian;
};

ftm_alarm0: timer@2800000 {
--
2.7.4

2020-09-28 16:56:13

by Leo Li

Subject: RE: [PATCH] arm64: dts: fix endianness of rcpm

> -----Original Message-----
> From: Ran Wang <[email protected]>
> Sent: Monday, September 28, 2020 4:05 AM
> To: Shawn Guo <[email protected]>; Leo Li <[email protected]>
> Cc: moderated list:ARM/FREESCALE LAYERSCAPE ARM ARCHITECTURE <linux-
> [email protected]>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <[email protected]>; open list
> <[email protected]>; Biwen Li <[email protected]>
> Subject: [PATCH] arm64: dts: fix endianness of rcpm
>
> From: Biwen Li <[email protected]>
>
> Add little-endian property of rcpm for ls1028a,ls1088a,ls208xa
>
> Signed-off-by: Biwen Li <[email protected]>

Acked-by: Li Yang <[email protected]>

> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 +
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 1 +
> arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 0efeb8f..651bfe1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -1012,6 +1012,7 @@
> compatible = "fsl,ls1028a-rcpm", "fsl,qoriq-rcpm-
> 2.1+";
> reg = <0x0 0x1e34040 0x0 0x1c>;
> #fsl,rcpm-wakeup-cells = <7>;
> + little-endian;
> };
>
> ftm_alarm0: timer@2800000 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 169f474..2ef812d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -787,6 +787,7 @@
> compatible = "fsl,ls1088a-rcpm", "fsl,qoriq-rcpm-
> 2.1+";
> reg = <0x0 0x1e34040 0x0 0x18>;
> #fsl,rcpm-wakeup-cells = <6>;
> + little-endian;
> };
>
> ftm_alarm0: timer@2800000 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> index 41102da..141b3d2 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> @@ -769,6 +769,7 @@
> compatible = "fsl,ls208xa-rcpm", "fsl,qoriq-rcpm-
> 2.1+";
> reg = <0x0 0x1e34040 0x0 0x18>;
> #fsl,rcpm-wakeup-cells = <6>;
> + little-endian;
> };
>
> ftm_alarm0: timer@2800000 {
> --
> 2.7.4

2020-09-28 19:24:32

by Fabio Estevam

Subject: Re: [PATCH] arm64: dts: fix endianness of rcpm

Hi Ran,

On Mon, Sep 28, 2020 at 6:14 AM Ran Wang <[email protected]> wrote:
>
> From: Biwen Li <[email protected]>
>
> Add little-endian property of rcpm for ls1028a,ls1088a,ls208xa
>
> Signed-off-by: Biwen Li <[email protected]>

You missed your Signed-off-by tag.

What about adding a Fixes tag?

2020-09-29 00:42:49

by Ran Wang

Subject: RE: [PATCH] arm64: dts: fix endianness of rcpm

Hi Fabio,

On Tuesday, September 29, 2020 3:20 AM, Fabio Estevam wrote:
>
> Hi Ran,
>
> On Mon, Sep 28, 2020 at 6:14 AM Ran Wang <[email protected]> wrote:
> >
> > From: Biwen Li <[email protected]>
> >
> > Add little-endian property of rcpm for ls1028a,ls1088a,ls208xa
> >
> > Signed-off-by: Biwen Li <[email protected]>
>
> You missed your Signed-off-by tag.

Oh, thanks for pointing out, will update in next version.

> What about adding a Fixes tag?

Sure, will add it.

Regards,
Ran