On 21/09/2023 08:36, Ming Qian wrote:
> There are total 4 slots available in the IP,
> and we only need to use one slot in one os,
> assign a single slot,
> configure interrupt and power domain only for 1 slot,
> not for the all 4 slots.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
>
> Signed-off-by: Ming Qian <[email protected]>
> ---
> .../bindings/media/nxp,imx8-jpeg.yaml | 40 ++++++++-----------
> 1 file changed, 16 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 3d9d1db37040..5f0e2fc1ea9c 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -32,25 +32,27 @@ properties:
> maxItems: 1
>
> interrupts:
> - description: |
> - There are 4 slots available in the IP, which the driver may use
> - If a certain slot is used, it should have an associated interrupt
> - The interrupt with index i is assumed to be for slot i
> - minItems: 1 # At least one slot is needed by the driver
> - maxItems: 4 # The IP has 4 slots available for use
> + description:
> + Interrupt number for slot
> + maxItems: 1
>
> power-domains:
> description:
> List of phandle and PM domain specifier as documented in
> Documentation/devicetree/bindings/power/power_domain.txt
> - minItems: 2 # Wrapper and 1 slot
> - maxItems: 5 # Wrapper and 4 slots
> + minItems: 1 # VPUMIX
> + maxItems: 2 # Wrapper and 1 slot
> +
> + slot:
> + description:
> + Integer number of slot index used. the value range is from 0 to 3
Don't you have here obvious errors reported by testing? Did you test this?
Best regards,
Krzysztof
>From: Krzysztof Kozlowski <[email protected]>
>Sent: 2023年9月21日 17:55
>To: Ming Qian <[email protected]>; Mirela Rabulea (OSS)
><[email protected]>; [email protected]; [email protected]
>Cc: [email protected]; [email protected]; [email protected];
>[email protected]; [email protected]; X.H. Bao
><[email protected]>; Eagle Zhou <[email protected]>; Tao Jiang
><[email protected]>; dl-linux-imx <[email protected]>; linux-
>[email protected]; [email protected]; linux-arm-
>[email protected]
>Subject: [EXT] Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for
>imx jpeg encoder/decoder
>
>Caution: This is an external email. Please take care when clicking links or
>opening attachments. When in doubt, report the message using the 'Report
>this email' button
>
>
>On 21/09/2023 08:36, Ming Qian wrote:
>> There are total 4 slots available in the IP, and we only need to use
>> one slot in one os, assign a single slot, configure interrupt and
>> power domain only for 1 slot, not for the all 4 slots.
>
>Please use scripts/get_maintainers.pl to get a list of necessary people and lists
>to CC. It might happen, that command when run on an older kernel, gives you
>outdated entries. Therefore please be sure you base your patches on recent
>Linux kernel.
>
>You missed at least devicetree list (maybe more), so this won't be tested by
>automated tooling. Performing review on untested code might be a waste of
>time, thus I will skip this patch entirely till you follow the process allowing the
>patch to be tested.
>
>Please kindly resend and include all necessary To/Cc entries.
>
>>
>> Signed-off-by: Ming Qian <[email protected]>
>> ---
>> .../bindings/media/nxp,imx8-jpeg.yaml | 40 ++++++++-----------
>> 1 file changed, 16 insertions(+), 24 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> index 3d9d1db37040..5f0e2fc1ea9c 100644
>> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> @@ -32,25 +32,27 @@ properties:
>> maxItems: 1
>>
>> interrupts:
>> - description: |
>> - There are 4 slots available in the IP, which the driver may use
>> - If a certain slot is used, it should have an associated interrupt
>> - The interrupt with index i is assumed to be for slot i
>> - minItems: 1 # At least one slot is needed by the driver
>> - maxItems: 4 # The IP has 4 slots available for use
>> + description:
>> + Interrupt number for slot
>> + maxItems: 1
>>
>> power-domains:
>> description:
>> List of phandle and PM domain specifier as documented in
>> Documentation/devicetree/bindings/power/power_domain.txt
>> - minItems: 2 # Wrapper and 1 slot
>> - maxItems: 5 # Wrapper and 4 slots
>> + minItems: 1 # VPUMIX
>> + maxItems: 2 # Wrapper and 1 slot
>> +
>> + slot:
>> + description:
>> + Integer number of slot index used. the value range is from 0 to
>> + 3
>
>Don't you have here obvious errors reported by testing? Did you test this?
>
>Best regards,
>Krzysztof
Hi Krzysztof,
Can you point out which test error? I run the dt_binding_check and didn't get any error.
make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTEX Documentation/devicetree/bindings/media/nxp,imx8-jpeg.example.dts
DTC_CHK Documentation/devicetree/bindings/media/nxp,imx8-jpeg.example.dtb
On 22/09/2023 03:33, Ming Qian wrote:
>> From: Krzysztof Kozlowski <[email protected]>
>> Sent: 2023年9月21日 17:55
>> To: Ming Qian <[email protected]>; Mirela Rabulea (OSS)
>> <[email protected]>; [email protected]; [email protected]
>> Cc: [email protected]; [email protected]; [email protected];
>> [email protected]; [email protected]; X.H. Bao
>> <[email protected]>; Eagle Zhou <[email protected]>; Tao Jiang
>> <[email protected]>; dl-linux-imx <[email protected]>; linux-
>> [email protected]; [email protected]; linux-arm-
>> [email protected]
>> Subject: [EXT] Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for
>> imx jpeg encoder/decoder
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On 21/09/2023 08:36, Ming Qian wrote:
>>> There are total 4 slots available in the IP, and we only need to use
>>> one slot in one os, assign a single slot, configure interrupt and
>>> power domain only for 1 slot, not for the all 4 slots.
>>
>> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
>> to CC. It might happen, that command when run on an older kernel, gives you
>> outdated entries. Therefore please be sure you base your patches on recent
>> Linux kernel.
>>
>> You missed at least devicetree list (maybe more), so this won't be tested by
>> automated tooling. Performing review on untested code might be a waste of
>> time, thus I will skip this patch entirely till you follow the process allowing the
>> patch to be tested.
>>
>> Please kindly resend and include all necessary To/Cc entries.
>>
>>>
>>> Signed-off-by: Ming Qian <[email protected]>
>>> ---
>>> .../bindings/media/nxp,imx8-jpeg.yaml | 40 ++++++++-----------
>>> 1 file changed, 16 insertions(+), 24 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>>> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>>> index 3d9d1db37040..5f0e2fc1ea9c 100644
>>> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>>> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>>> @@ -32,25 +32,27 @@ properties:
>>> maxItems: 1
>>>
>>> interrupts:
>>> - description: |
>>> - There are 4 slots available in the IP, which the driver may use
>>> - If a certain slot is used, it should have an associated interrupt
>>> - The interrupt with index i is assumed to be for slot i
>>> - minItems: 1 # At least one slot is needed by the driver
>>> - maxItems: 4 # The IP has 4 slots available for use
>>> + description:
>>> + Interrupt number for slot
>>> + maxItems: 1
>>>
>>> power-domains:
>>> description:
>>> List of phandle and PM domain specifier as documented in
>>> Documentation/devicetree/bindings/power/power_domain.txt
>>> - minItems: 2 # Wrapper and 1 slot
>>> - maxItems: 5 # Wrapper and 4 slots
>>> + minItems: 1 # VPUMIX
>>> + maxItems: 2 # Wrapper and 1 slot
>>> +
>>> + slot:
>>> + description:
>>> + Integer number of slot index used. the value range is from 0 to
>>> + 3
>>
>> Don't you have here obvious errors reported by testing? Did you test this?
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
> Can you point out which test error? I run the dt_binding_check and didn't get any error.
Hm, I guess we need to add some checks for this... You miss type and
vendor prefix. This does not look like generic property. Constraints are
also missing, but that's minor. The main point is that this does not
look suitable for DT at all. Your description says nothing - copies
property name. Commit msg also does not explain it.
Best regards,
Krzysztof