2020-03-24 07:05:52

by Yue Haibing

Subject: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'

drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np' [-Wunused-variable]
struct device_node *np = pdev->dev.of_node;
^~
commit cd49b579e705 ("rtc: fsl-ftm-alarm: enable acpi support")
left behind this, remove it.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
index c572044ff06e..0f4142b35f38 100644
--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
@@ -243,7 +243,6 @@ static const struct rtc_class_ops ftm_rtc_ops = {

static int ftm_rtc_probe(struct platform_device *pdev)
{
- struct device_node *np = pdev->dev.of_node;
int irq;
int ret;
struct ftm_rtc *rtc;
--
2.17.1

2020-03-25 01:51:27

by Peng Ma

Subject: RE: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'

>-----Original Message-----
>From: YueHaibing <[email protected]>
>Sent: 2020??3??24?? 15:04
>To: [email protected]; [email protected]
>Cc: [email protected]; [email protected]; Peng Ma
><[email protected]>; YueHaibing <[email protected]>
>Subject: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'
>
>drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
>drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np'
>[-Wunused-variable]
> struct device_node *np = pdev->dev.of_node;
> ^~
>commit cd49b579e705 ("rtc: fsl-ftm-alarm: enable acpi support") left behind
>this, remove it.
>
>Signed-off-by: YueHaibing <[email protected]>
>---
> drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c index
>c572044ff06e..0f4142b35f38 100644
>--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
>+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
>@@ -243,7 +243,6 @@ static const struct rtc_class_ops ftm_rtc_ops = {
>
> static int ftm_rtc_probe(struct platform_device *pdev) {
>- struct device_node *np = pdev->dev.of_node;
[Peng Ma] Hi, HaiBing,

Thanks for your patch, this patch has already in upstream(https://lore.kernel.org/patchwork/patch/1214014/)

Best Regards,
Peng
> int irq;
> int ret;
> struct ftm_rtc *rtc;
>--
>2.17.1
>