2020-03-23 07:34:25

by Peng Ma

Subject: [PATCH] rtc: fsl-ftm-alarm: remove the useless variable

Remove the useless variable to fixed the below build warning:
drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np' [-Wunused-variable]
struct device_node *np = pdev->dev.of_node;

Signed-off-by: Peng Ma <[email protected]>
---
drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
index c572044..0f4142b 100644
--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
@@ -243,7 +243,6 @@ static const struct rtc_class_ops ftm_rtc_ops = {

static int ftm_rtc_probe(struct platform_device *pdev)
{
- struct device_node *np = pdev->dev.of_node;
int irq;
int ret;
struct ftm_rtc *rtc;
--
2.9.5

2020-03-23 08:29:40

by Alexandre Belloni

Subject: Re: [PATCH] rtc: fsl-ftm-alarm: remove the useless variable

On 23/03/2020 15:29:56+0800, Peng Ma wrote:
> Remove the useless variable to fixed the below build warning:
> drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
> drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np' [-Wunused-variable]
> struct device_node *np = pdev->dev.of_node;
>
> Signed-off-by: Peng Ma <[email protected]>
> ---
> drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
> 1 file changed, 1 deletion(-)
>

I squashed it in the offending commit.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2020-03-23 09:16:24

by Peng Ma

Subject: RE: [EXT] Re: [PATCH] rtc: fsl-ftm-alarm: remove the useless variable

>-----Original Message-----
>From: Alexandre Belloni <[email protected]>
>Sent: 2020??3??23?? 16:29
>To: Peng Ma <[email protected]>
>Cc: [email protected]; [email protected];
>[email protected]; Leo Li <[email protected]>; Ran Wang
><[email protected]>; Biwen Li <[email protected]>
>Subject: [EXT] Re: [PATCH] rtc: fsl-ftm-alarm: remove the useless variable
>
>Caution: EXT Email
>
>On 23/03/2020 15:29:56+0800, Peng Ma wrote:
>> Remove the useless variable to fixed the below build warning:
>> drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
>> drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np'
>[-Wunused-variable]
>> struct device_node *np = pdev->dev.of_node;
>>
>> Signed-off-by: Peng Ma <[email protected]>
>> ---
>> drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
>I squashed it in the offending commit.
[Peng Ma] OK??Got it, thanks

Best Regards,
Peng
>--
>Alexandre Belloni, Bootlin
>Embedded Linux and Kernel engineering
>https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
>om&amp;data=02%7C01%7Cpeng.ma%40nxp.com%7Cd3d60d9c26524805b352
>08d7cf043999%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6372054
>89372736346&amp;sdata=wb4bBcP8dMbriAdZFnSgl44JokZ0AK6MsGa7z6CWGlg
>%3D&amp;reserved=0