2022-06-23 10:09:24

by Felix Schlepper

[permalink] [raw]
Subject: [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling


v2:
- replaced kmalloc with kzalloc against memory initialization defects,
thus also removing a memset
- made error handling more consistent

v3:
- Split into smaller commits so that it's easier to review

v4:
- clearer commit messages
- added missing kfree

Felix Schlepper (3):
Staging: rtl8192e: Use struct_size
Staging: rtl8192e: Using kzalloc and delete memset
Staging: rtl8192e: Cleaning up error handling

drivers/staging/rtl8192e/rtllib_tx.c | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)

--
2.36.1


2022-06-23 10:27:11

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling

Thanks!

Reviewed-by: Dan Carpenter <[email protected]>

regards,
dan carpenter

2022-06-23 11:34:56

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling

On Thu, Jun 23, 2022 at 12:05:54PM +0200, Felix Schlepper wrote:
>
> v2:
> - replaced kmalloc with kzalloc against memory initialization defects,
> thus also removing a memset
> - made error handling more consistent
>
> v3:
> - Split into smaller commits so that it's easier to review
>
> v4:
> - clearer commit messages
> - added missing kfree
>
> Felix Schlepper (3):
> Staging: rtl8192e: Use struct_size
> Staging: rtl8192e: Using kzalloc and delete memset
> Staging: rtl8192e: Cleaning up error handling
>
> drivers/staging/rtl8192e/rtllib_tx.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
> --
> 2.36.1
>

Why is this not properly threaded with the patches itself? Please
resend so that our tools will pick them all up correctly.

thanks,

greg k-h

2022-06-23 13:56:22

by Felix Schlepper

[permalink] [raw]
Subject: Re: [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner error handling

On 23.06.2022 12:47, Greg KH wrote:
> On Thu, Jun 23, 2022 at 12:05:54PM +0200, Felix Schlepper wrote:
> >
> > v2:
> > - replaced kmalloc with kzalloc against memory initialization defects,
> > thus also removing a memset
> > - made error handling more consistent
> >
> > v3:
> > - Split into smaller commits so that it's easier to review
> >
> > v4:
> > - clearer commit messages
> > - added missing kfree
> >
> > Felix Schlepper (3):
> > Staging: rtl8192e: Use struct_size
> > Staging: rtl8192e: Using kzalloc and delete memset
> > Staging: rtl8192e: Cleaning up error handling
> >
> > drivers/staging/rtl8192e/rtllib_tx.c | 24 +++++++++++-------------
> > 1 file changed, 11 insertions(+), 13 deletions(-)
> >
> > --
> > 2.36.1
> >
>
> Why is this not properly threaded with the patches itself? Please
> resend so that our tools will pick them all up correctly.
>
> thanks,
>
> greg k-h
I am trying... I thought I figured it out with the help of kernelnewbies
irc, but I resend and it is still not threaded properly.
I tried to reply to the message-id with the patchseries,which worked
locally, but I am just
causing a mess on the mailing list at this point. Will try to figure
this out properly.

Cheers
Felix Schlepper