2022-07-19 22:22:11

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high'

'reset-gpio-active-high' is missing a type definition and is not a common
property. The type is boolean.

Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 252e5b72aee0..376e739bcad4 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -144,6 +144,7 @@ properties:
description: If present then the reset sequence using the GPIO
specified in the "reset-gpio" property is reversed (H=reset state,
L=operation state) (optional required).
+ type: boolean

vpcie-supply:
description: Should specify the regulator in charge of PCIe port power.
--
2.34.1


2022-07-20 02:04:44

by Richard Zhu

[permalink] [raw]
Subject: RE: [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high'

Hi Rob:
Thanks for your kindly help.

> -----Original Message-----
> From: Rob Herring <[email protected]>
> Sent: 2022??7??20?? 5:51
> To: Hongxing Zhu <[email protected]>; Lucas Stach
> <[email protected]>; Bjorn Helgaas <[email protected]>; Krzysztof
> Kozlowski <[email protected]>; Shawn Guo
> <[email protected]>; Sascha Hauer <[email protected]>;
> Pengutronix Kernel Team <[email protected]>; Fabio Estevam
> <[email protected]>; dl-linux-imx <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for
> 'reset-gpio-active-high'
>
> 'reset-gpio-active-high' is missing a type definition and is not a common
> property. The type is boolean.
>
> Signed-off-by: Rob Herring <[email protected]>
Acked-by: Richard Zhu <[email protected]>

Best Regards
Richard Zhu
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 252e5b72aee0..376e739bcad4 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -144,6 +144,7 @@ properties:
> description: If present then the reset sequence using the GPIO
> specified in the "reset-gpio" property is reversed (H=reset state,
> L=operation state) (optional required).
> + type: boolean
>
> vpcie-supply:
> description: Should specify the regulator in charge of PCIe port power.
> --
> 2.34.1

2022-07-20 21:42:53

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high'

On Tue, Jul 19, 2022 at 03:50:31PM -0600, Rob Herring wrote:
> 'reset-gpio-active-high' is missing a type definition and is not a common
> property. The type is boolean.
>
> Signed-off-by: Rob Herring <[email protected]>

You've merged previous updates, Rob, so I assume you'll do the same
with this.

> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 252e5b72aee0..376e739bcad4 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -144,6 +144,7 @@ properties:
> description: If present then the reset sequence using the GPIO
> specified in the "reset-gpio" property is reversed (H=reset state,
> L=operation state) (optional required).
> + type: boolean
>
> vpcie-supply:
> description: Should specify the regulator in charge of PCIe port power.
> --
> 2.34.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2022-07-22 22:26:25

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high'

On Tue, 19 Jul 2022 15:50:31 -0600, Rob Herring wrote:
> 'reset-gpio-active-high' is missing a type definition and is not a common
> property. The type is boolean.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Applied, thanks!