Hi all,
After merging the tip tree, today's linux-next build (htmldocs) produced
these warnings:
Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
Introduced by commit
7ac2f1017115 ("x86/platform/uv: Update ABI documentation of /sys/firmware/sgi_uv/")
--
Cheers,
Stephen Rothwell
On Mon, Nov 30, 2020 at 06:05:03PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the tip tree, today's linux-next build (htmldocs) produced
> these warnings:
>
> Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
> Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
> Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
>
> Introduced by commit
>
> 7ac2f1017115 ("x86/platform/uv: Update ABI documentation of /sys/firmware/sgi_uv/")
Yah, I can reproduce but I have no clue what sphinx wants from me. Line
2 looks ok which could mean that the warning line it points to is bogus.
Justin, this is all yours. :)
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
> On Mon, Nov 30, 2020 at 06:05:03PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the tip tree, today's linux-next build (htmldocs) produced
> > these warnings:
> >
> > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
> > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
> > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
> >
> > Introduced by commit
> >
> > 7ac2f1017115 ("x86/platform/uv: Update ABI documentation of /sys/firmware/sgi_uv/")
>
> Yah, I can reproduce but I have no clue what sphinx wants from me. Line
> 2 looks ok which could mean that the warning line it points to is bogus.
>
> Justin, this is all yours. :)
After scratching my head for a while, I found that the issue was missing empty lines before three different code-block sections.
The line number is definitely bogus, but I wasn't able to discover why.
You can find my patch at: https://lkml.org/lkml/2020/11/30/1196
The patch depends on the v2 patch set Mike Travis <[email protected]> submitted, which hasn't made it to tip yet.
Thanks,
-Justin
>
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
On Mon, Nov 30, 2020 at 09:56:27PM +0000, Ernst, Justin wrote:
> After scratching my head for a while, I found that the issue was
> missing empty lines before three different code-block sections.
Oh great.
> The line number is definitely bogus, but I wasn't able to discover
> why.
Very helpful that tool. :-\
> You can find my patch at: https://lkml.org/lkml/2020/11/30/1196 The
> patch depends on the v2 patch set Mike Travis <[email protected]>
> submitted, which hasn't made it to tip yet.
Yeah, thanks for figuring this out.
I'll simply rebase your previous patch on the tip:x86/platform branch
since it is documentation stuff only and there's only one patch ontop
which updates MAINTAINERS but I don't think it'll be the end of the
world if those two got rebased.
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg