2015-04-16 15:21:56

by Chen Gang

[permalink] [raw]
Subject: [Consult] blackfin: About one building break issue for STACKTRACE

Hello Maintainers:

I want to consult one building issue about blackfin, the related issue
is:

CC arch/blackfin/kernel/stacktrace.o
arch/blackfin/kernel/stacktrace.c: In function 'save_stack_trace':
arch/blackfin/kernel/stacktrace.c:23:6: error: frame pointer required, but reserved
void save_stack_trace(struct stack_trace *trace)
^
arch/blackfin/kernel/stacktrace.c:13:24: note: for 'current_frame_pointer'
register unsigned long current_frame_pointer asm("FP");
^

For me:

- Originally, I treated it as gcc's issue, but after think of, for me,
gcc is OK:

"-fomit-frame-pointer" is needed by extern "FP" pointer.

"-fomit-frame-pointer" is against "-pg" (they can not be together).

- For kernel:

STACKTRACE needs "-fomit-frame-pointer", and FUNCTION_TRACER will
enable "-pg",

FUNCTION_TRACER and STACKTRACE are related.

The related commit: "1c873be Blackfin: initial support for ftrace"
(the commit time point is Jun 9 2009).

- After this related commit, it never can pass building by upstream
blackfin gcc5:

make defconfig && make menuconfig

enable FUNCTION_TRACER (which also enable STACKTRACE)

make (which will cause building break)

So I want to consult:

- Is it OK to use upstream gcc5 for blackfin? (or which gcc version is
suitable for building blackfin Linux kernel?)

- Did the original commit pass building ? (e.g. by one of old gcc
version).

- How to fix this issue, next?


Welcome any members ideas, suggestions and completions.

Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed


2015-04-17 03:17:33

by Zhang, Sonic

[permalink] [raw]
Subject: RE: [Adi-buildroot-devel] [Consult] blackfin: About one building break issue for STACKTRACE

Hi Gang,

Please only use the GCC for Blackfin 2013R1 or 2014R1 from https://sourceforge.net/projects/adi-buildroot/files/ . Upstream GCC5 isn't ported to Blackfin properly.

Regards,

Sonic

>-----Original Message-----
>From: Chen Gang [mailto:[email protected]]
>Sent: Thursday, April 16, 2015 11:22 PM
>To: [email protected]; Richard Weinberger
>Cc: [email protected]; [email protected]
>Subject: [Adi-buildroot-devel] [Consult] blackfin: About one building break issue for STACKTRACE
>
>Hello Maintainers:
>
>I want to consult one building issue about blackfin, the related issue
>is:
>
> CC arch/blackfin/kernel/stacktrace.o
> arch/blackfin/kernel/stacktrace.c: In function 'save_stack_trace':
> arch/blackfin/kernel/stacktrace.c:23:6: error: frame pointer required, but reserved
> void save_stack_trace(struct stack_trace *trace)
> ^
> arch/blackfin/kernel/stacktrace.c:13:24: note: for 'current_frame_pointer'
> register unsigned long current_frame_pointer asm("FP");
> ^
>
>For me:
>
> - Originally, I treated it as gcc's issue, but after think of, for me,
> gcc is OK:
>
> "-fomit-frame-pointer" is needed by extern "FP" pointer.
>
> "-fomit-frame-pointer" is against "-pg" (they can not be together).
>
> - For kernel:
>
> STACKTRACE needs "-fomit-frame-pointer", and FUNCTION_TRACER will
> enable "-pg",
>
> FUNCTION_TRACER and STACKTRACE are related.
>
> The related commit: "1c873be Blackfin: initial support for ftrace"
> (the commit time point is Jun 9 2009).
>
> - After this related commit, it never can pass building by upstream
> blackfin gcc5:
>
> make defconfig && make menuconfig
>
> enable FUNCTION_TRACER (which also enable STACKTRACE)
>
> make (which will cause building break)
>
>So I want to consult:
>
> - Is it OK to use upstream gcc5 for blackfin? (or which gcc version is
> suitable for building blackfin Linux kernel?)
>
> - Did the original commit pass building ? (e.g. by one of old gcc
> version).
>
> - How to fix this issue, next?
>
>
>Welcome any members ideas, suggestions and completions.
>
>Thanks.
>--
>Chen Gang
>
>Open, share, and attitude like air, water, and life which God blessed
>
>------------------------------------------------------------------------------
>BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN
>2 standard Learn Process modeling best practices with Bonita BPM through live exercises
>http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
>source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
>_______________________________________________
>Adi-buildroot-devel mailing list
>[email protected]
>https://lists.sourceforge.net/lists/listinfo/adi-buildroot-devel

2015-04-17 14:02:37

by Chen Gang

[permalink] [raw]
Subject: Re: [Adi-buildroot-devel] [Consult] blackfin: About one building break issue for STACKTRACE

On 4/17/15 11:02, Zhang, Sonic wrote:
> Hi Gang,
>
> Please only use the GCC for Blackfin 2013R1 or 2014R1 from https://sourceforge.net/projects/adi-buildroot/files/ . Upstream GCC5 isn't ported to Blackfin properly.
>

OK, thank you very much for your reply. :-)


For me, I want to let gcc5 support Blackfin properly, but sorry, at
present I can not.

- In honest, I am still not quite familiar with gcc (although I am
trying and improving).

- This year, I have no enough time resource for it (I am mainly for
upstream qemu this year).

But if next year, upstream gcc is still not ported to Blackfin properly,
I shall try.

However, there are still several another issues for upstream blackfin
gcc5 (they are all coredumps), I should still try to analyze them and
find root causes, hope I can finish within this month.


Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

2015-04-17 22:19:56

by Chen Gang

[permalink] [raw]
Subject: Re: [Adi-buildroot-devel] [Consult] blackfin: About one building break issue for STACKTRACE

On 4/17/15 22:02, Chen Gang wrote:
> On 4/17/15 11:02, Zhang, Sonic wrote:
>> Hi Gang,
>>
>> Please only use the GCC for Blackfin 2013R1 or 2014R1 from https://sourceforge.net/projects/adi-buildroot/files/ . Upstream GCC5 isn't ported to Blackfin properly.
>>

However, I should still try to consult gcc members for this issue. At
least, I should report to Bugzilla and try to find root cause (although
I can not fix it, at present).

>
> OK, thank you very much for your reply. :-)
>
>
> For me, I want to let gcc5 support Blackfin properly, but sorry, at
> present I can not.
>
> - In honest, I am still not quite familiar with gcc (although I am
> trying and improving).
>
> - This year, I have no enough time resource for it (I am mainly for
> upstream qemu this year).
>
> But if next year, upstream gcc is still not ported to Blackfin properly,
> I shall try.
>
> However, there are still several another issues for upstream blackfin
> gcc5 (they are all coredumps), I should still try to analyze them and
> find root causes, hope I can finish within this month.
>
>
> Thanks.
>

Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

2015-04-19 04:58:31

by Chen Gang

[permalink] [raw]
Subject: Re: [Adi-buildroot-devel] [Consult] blackfin: About one building break issue for STACKTRACE

On 4/18/15 06:20, Chen Gang wrote:
> On 4/17/15 22:02, Chen Gang wrote:
>> On 4/17/15 11:02, Zhang, Sonic wrote:
>>> Hi Gang,
>>>
>>> Please only use the GCC for Blackfin 2013R1 or 2014R1 from https://sourceforge.net/projects/adi-buildroot/files/ . Upstream GCC5 isn't ported to Blackfin properly.
>>>

For building linux-next with allmodconfig by upstream gcc5, at present, I
found 2 issues totally, and report them to upstream gcc bugzilla:

- For stacktrace.c issue:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65804
"blackfin: Not support global frame pointer with -fno-omit-frame-pointer"

- For coredump issues (for duplication reason, only report one, now):

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65803
"blackfin: internal compiler error: segment fault linux kernel"

At least, I shall try to fix the coredump issues within this month (
although at present, I guess, I can not send patch v1 for it within
2015-04-20).


Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed