2013-03-03 09:24:47

by Grant Likely

[permalink] [raw]
Subject: Re: [PATCH v5 01/16] spi/spi-atmel: fix master->num_chipselect wrongly set.

On Tue, 26 Feb 2013 14:47:54 +0800, Wenyou Yang <[email protected]> wrote:
> if the spi property "cs-gpios" is set as below:
>
> cs-gpios = <0>, <&pioC 11 0>, <0>, <0>;
>
> the master->num_chipselect will wrongly be set to 0,
> and the spi fail to probe.
>
> Signed-off-by: Wenyou Yang <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

I think I've got this bug fixed in the core spi code. Give it a couple
of days and retest with linux-next.

g.


2013-03-08 00:59:56

by Wenyou Yang

[permalink] [raw]
Subject: RE: [PATCH v5 01/16] spi/spi-atmel: fix master->num_chipselect wrongly set.

> -----Original Message-----
> From: Grant Likely [mailto:[email protected]] On Behalf Of Grant Likely
> Sent: 2013??3??3?? 7:16
> To: Yang, Wenyou; [email protected]
> Cc: Ferre, Nicolas; [email protected]; [email protected]; Lin, JM;
> Yang, Wenyou; [email protected];
> [email protected]
> Subject: Re: [PATCH v5 01/16] spi/spi-atmel: fix master->num_chipselect
> wrongly set.
>
> On Tue, 26 Feb 2013 14:47:54 +0800, Wenyou Yang <[email protected]>
> wrote:
> > if the spi property "cs-gpios" is set as below:
> >
> > cs-gpios = <0>, <&pioC 11 0>, <0>, <0>;
> >
> > the master->num_chipselect will wrongly be set to 0,
> > and the spi fail to probe.
> >
> > Signed-off-by: Wenyou Yang <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
>
> I think I've got this bug fixed in the core spi code. Give it a couple
> of days and retest with linux-next.
Hi Grant,

Yes, in v3.9-rc1 this bug fixed, I retested on v3.9-rc1.
But on "spi/next" git tree, it should to apply this patch.

I sent the patches version 6, could you take a look them?
Thanks a lot for your work.

>
> g.

Best Regards,
Wenyou Yang
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?