2013-03-19 07:47:15

by Wenyou Yang

[permalink] [raw]
Subject: [PATCH v7 03/14] spi/spi-atmel: add physical base address

From: Nicolas Ferre <[email protected]>

Needed for future use with dmaengine enabled driver.

Signed-off-by: Nicolas Ferre <[email protected]>
Cc: [email protected]
Cc: [email protected]
[[email protected]: submit the patch]
Signed-off-by: Wenyou Yang <[email protected]>
---
drivers/spi/spi-atmel.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 64e2795..f3e1cd8 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -196,6 +196,7 @@ struct atmel_spi_caps {
struct atmel_spi {
spinlock_t lock;

+ resource_size_t phybase;
void __iomem *regs;
int irq;
struct clk *clk;
@@ -993,6 +994,7 @@ static int atmel_spi_probe(struct platform_device *pdev)
as->regs = ioremap(regs->start, resource_size(regs));
if (!as->regs)
goto out_free_buffer;
+ as->phybase = regs->start;
as->irq = irq;
as->clk = clk;

--
1.7.9.5


2013-04-01 13:41:51

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v7 03/14] spi/spi-atmel: add physical base address

On Tue, Mar 19, 2013 at 03:43:36PM +0800, Wenyou Yang wrote:

> +++ b/drivers/spi/spi-atmel.c
> @@ -196,6 +196,7 @@ struct atmel_spi_caps {
> struct atmel_spi {
> spinlock_t lock;
>
> + resource_size_t phybase;
> void __iomem *regs;
> int irq;
> struct clk *clk;

This looks like the wrong type?

Attachments:
(No filename) (313.00 B)
 signature.asc (836.00 B)
Digital signature Download all attachments

2013-04-02 05:50:06

by Wenyou Yang

[permalink] [raw]
Subject: RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address

Hi, Mark,

> -----Original Message-----
> From: Mark Brown [mailto:[email protected]]
> Sent: 2013??4??1?? 21:42
> To: Yang, Wenyou
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Ferre, Nicolas; Lin, JM;
> [email protected]; [email protected]
> Subject: Re: [PATCH v7 03/14] spi/spi-atmel: add physical base address
>
> On Tue, Mar 19, 2013 at 03:43:36PM +0800, Wenyou Yang wrote:
>
> > +++ b/drivers/spi/spi-atmel.c
> > @@ -196,6 +196,7 @@ struct atmel_spi_caps { struct atmel_spi {
> > spinlock_t lock;
> >
> > + resource_size_t phybase;
> > void __iomem *regs;
> > int irq;
> > struct clk *clk;
>
> This looks like the wrong type?

I double checked.

The type ' resource_size_t ' is defined in include/linux/ types.h as below,

typedef phys_addr_t resource_size_t;

I think it is OK.

Best Regards,
Wenyou Yang
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?

2013-04-02 06:17:17

by Wenyou Yang

[permalink] [raw]
Subject: RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address

Hi, Mark,

> -----Original Message-----
> From: Yang, Wenyou
> Sent: 2013??4??2?? 13:50
> To: 'Mark Brown'
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Ferre, Nicolas; Lin, JM;
> [email protected]; [email protected]
> Subject: RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address
>
> Hi, Mark,
>
> > -----Original Message-----
> > From: Mark Brown [mailto:[email protected]]
> > Sent: 2013??4??1?? 21:42
> > To: Yang, Wenyou
> > Cc: [email protected]; [email protected];
> > [email protected]; [email protected]; Ferre, Nicolas; Lin, JM;
> > [email protected]; [email protected]
> > Subject: Re: [PATCH v7 03/14] spi/spi-atmel: add physical base address
> >
> > On Tue, Mar 19, 2013 at 03:43:36PM +0800, Wenyou Yang wrote:
> >
> > > +++ b/drivers/spi/spi-atmel.c
> > > @@ -196,6 +196,7 @@ struct atmel_spi_caps { struct atmel_spi {
> > > spinlock_t lock;
> > >
> > > + resource_size_t phybase;
> > > void __iomem *regs;
> > > int irq;
> > > struct clk *clk;
> >
> > This looks like the wrong type?
>
I got it, you are right, you mean It should be used " phys_addr_t " type.

phys_addr_t phybase;

Thanks.

Best Regards,
Wenyou Yang.

> I double checked.
>
> The type ' resource_size_t ' is defined in include/linux/ types.h as below,
>
> typedef phys_addr_t resource_size_t;
>
> I think it is OK.
>
> Best Regards,
> Wenyou Yang
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?