2016-03-07 23:56:11

by kernel test robot

Subject: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings

drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Wenyou Yang <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---

act8945a.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/mfd/act8945a.c
+++ b/drivers/mfd/act8945a.c
@@ -97,7 +97,6 @@ MODULE_DEVICE_TABLE(of, act8945a_of_matc
static struct i2c_driver act8945a_i2c_driver = {
.driver = {
.name = "act8945a",
- .owner = THIS_MODULE,
.of_match_table = of_match_ptr(act8945a_of_match),
},
.probe = act8945a_i2c_probe,

2016-03-08 01:56:47

by Wenyou Yang

Subject: RE: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings

Hi Fengguang Wu,

Thank you for your patch.

> -----Original Message-----
> From: kbuild test robot [mailto:[email protected]]
> Sent: 2016??3??8?? 7:54
> To: Yang, Wenyou <[email protected]>
> Cc: [email protected]; Lee Jones <[email protected]>; Rob Herring
> <[email protected]>; Pawel Moll <[email protected]>; Mark Rutland
> <[email protected]>; Ian Campbell <[email protected]>; Kumar
> Gala <[email protected]>; Ferre, Nicolas <[email protected]>;
> [email protected]; [email protected]; Yang, Wenyou
> <[email protected]>
> Subject: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings
>
> drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: Wenyou Yang <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>

Reviewed-by: Wenyou Yang <[email protected]>

> ---
>
> act8945a.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/mfd/act8945a.c
> +++ b/drivers/mfd/act8945a.c
> @@ -97,7 +97,6 @@ MODULE_DEVICE_TABLE(of, act8945a_of_matc static
> struct i2c_driver act8945a_i2c_driver = {
> .driver = {
> .name = "act8945a",
> - .owner = THIS_MODULE,
> .of_match_table = of_match_ptr(act8945a_of_match),
> },
> .probe = act8945a_i2c_probe,


Best Regards,
Wenyou Yang

2016-03-08 04:51:18

by Lee Jones

Subject: Re: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings

On Tue, 08 Mar 2016, Yang, Wenyou wrote:

> Hi Fengguang Wu,
>
> Thank you for your patch.
>
> > -----Original Message-----
> > From: kbuild test robot [mailto:[email protected]]
> > Sent: 2016年3月8日 7:54
> > To: Yang, Wenyou <[email protected]>
> > Cc: [email protected]; Lee Jones <[email protected]>; Rob Herring
> > <[email protected]>; Pawel Moll <[email protected]>; Mark Rutland
> > <[email protected]>; Ian Campbell <[email protected]>; Kumar
> > Gala <[email protected]>; Ferre, Nicolas <[email protected]>;
> > [email protected]; [email protected]; Yang, Wenyou
> > <[email protected]>
> > Subject: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings
> >
> > drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.
> >
> > Remove .owner field if calls are used which set it automatically
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > CC: Wenyou Yang <[email protected]>
> > Signed-off-by: Fengguang Wu <[email protected]>
>
> Reviewed-by: Wenyou Yang <[email protected]>

Please fix this code up into the original patch and resubmit the set.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog