2017-12-11 20:12:59

by Sebastian Sjoholm

[permalink] [raw]
Subject: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

From: Sebastian Sjoholm <[email protected]>

Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both
CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development
board (EVB). The USB id is added to qmi_wwan.c to allow QMI
communication with the BG96.

Signed-off-by: Sebastian Sjoholm <[email protected]>

---
drivers/net/usb/qmi_wwan.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 720a3a248070..c750cf7c042b 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1239,6 +1239,7 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x1e0e, 0x9001, 5)}, /* SIMCom 7230E */
{QMI_QUIRK_SET_DTR(0x2c7c, 0x0125, 4)}, /* Quectel EC25, EC20 R2.0 Mini PCIe */
{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
+ {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */

/* 4. Gobi 1000 devices */
{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
--
2.11.0 (Apple Git-81)


2017-12-11 20:13:37

by Sebastian Sjoholm

[permalink] [raw]
Subject: [PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

From: Sebastian Sjoholm <[email protected]>

From: Sebastian Sjoholm <[email protected]>

Sierra Wireless EM7565 is an Qualcomm MDM9x50 based M.2 modem.
The USB id is added to qmi_wwan.c to allow QMI communication with the EM7565.

Signed-off-by: Sebastian Sjoholm <[email protected]>
---
[The corresponding qcserial patch will be submitted by Reinhard Speyerer.]

---
drivers/net/usb/qmi_wwan.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 304ec6555cd8..3cebd6683938 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1204,6 +1204,7 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x1199, 0x9079, 10)}, /* Sierra Wireless EM74xx */
{QMI_FIXED_INTF(0x1199, 0x907b, 8)}, /* Sierra Wireless EM74xx */
{QMI_FIXED_INTF(0x1199, 0x907b, 10)}, /* Sierra Wireless EM74xx */
+ {QMI_FIXED_INTF(0x1199, 0x9091, 8)}, /* Sierra Wireless EM7565 */
{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
{QMI_FIXED_INTF(0x1bbb, 0x0203, 2)}, /* Alcatel L800MA */
{QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
--
2.14.1

2017-12-11 20:15:32

by Sebastian Sjoholm

[permalink] [raw]
Subject: Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

Hi,

Sorry for the re-email of the patch below, clearly a beginners mistake of me not to clear my tmp/ folder.

Please disregard this.

Regards,
Sebastian

> On Dec 11, 2017, at 21:12 , [email protected] wrote:
>
> From: Sebastian Sjoholm <[email protected]>
>
> Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both
> CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development
> board (EVB). The USB id is added to qmi_wwan.c to allow QMI
> communication with the BG96.
>
> Signed-off-by: Sebastian Sjoholm <[email protected]>
>
> ---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 720a3a248070..c750cf7c042b 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1239,6 +1239,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x1e0e, 0x9001, 5)}, /* SIMCom 7230E */
> {QMI_QUIRK_SET_DTR(0x2c7c, 0x0125, 4)}, /* Quectel EC25, EC20 R2.0 Mini PCIe */
> {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
> + {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */
>
> /* 4. Gobi 1000 devices */
> {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
> --
> 2.11.0 (Apple Git-81)
>


2017-12-11 20:38:50

by Bjørn Mork

[permalink] [raw]
Subject: Re: [PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

[email protected] writes:

> From: Sebastian Sjoholm <[email protected]>
>
> From: Sebastian Sjoholm <[email protected]>
>
> Sierra Wireless EM7565 is an Qualcomm MDM9x50 based M.2 modem.
> The USB id is added to qmi_wwan.c to allow QMI communication with the EM7565.
>
> Signed-off-by: Sebastian Sjoholm <[email protected]>
> ---
> [The corresponding qcserial patch will be submitted by Reinhard Speyerer.]
>
> ---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 304ec6555cd8..3cebd6683938 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1204,6 +1204,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x1199, 0x9079, 10)}, /* Sierra Wireless EM74xx */
> {QMI_FIXED_INTF(0x1199, 0x907b, 8)}, /* Sierra Wireless EM74xx */
> {QMI_FIXED_INTF(0x1199, 0x907b, 10)}, /* Sierra Wireless EM74xx */
> + {QMI_FIXED_INTF(0x1199, 0x9091, 8)}, /* Sierra Wireless EM7565 */
> {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
> {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)}, /* Alcatel L800MA */
> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */

Looks good except for the duplicate 'From' line. Drop that and you can
add

Acked-by: Bjørn Mork <[email protected]>


2017-11-20 06:58:16

by Bjørn Mork

[permalink] [raw]
Subject: Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296



On November 20, 2017 5:19:21 AM GMT+01:00, [email protected] wrote:
>From: ssjoholm <[email protected]>
>
>Signed-off-by: ssjoholm <[email protected]>
>
>Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both
>CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel
>development board (EVB).
>The USB id is added to qmi_wwan.c to allow QMI communication with the
>BG96.
>---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>index 720a3a248070..c750cf7c042b 100644
>--- a/drivers/net/usb/qmi_wwan.c
>+++ b/drivers/net/usb/qmi_wwan.c
>@@ -1239,6 +1239,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x1e0e, 0x9001, 5)}, /* SIMCom 7230E */
> {QMI_QUIRK_SET_DTR(0x2c7c, 0x0125, 4)}, /* Quectel EC25, EC20 R2.0
>Mini PCIe */
> {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
>+ {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */
>
> /* 4. Gobi 1000 devices */
> {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */

Patch looks fine. But you need to use your full name in the tags.
See the part about identity;
https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup

And the SOB and other tags go after the rest of the commit message. Your SOB should always be the last line.



Bjørn

From 1584561111076651488@xxx Mon Nov 20 05:20:34 +0000 2017
X-GM-THRID: 1584561111076651488
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread

2017-11-21 11:19:30

by David Miller

[permalink] [raw]
Subject: Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

From: Sebastian Sjoholm <[email protected]>
Date: Mon, 20 Nov 2017 19:05:17 +0100

> Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both
> CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development
> board (EVB). The USB id is added to qmi_wwan.c to allow QMI
> communication with the BG96.
>
> Signed-off-by: Sebastian Sjoholm <[email protected]>

Applied and queued up for -stable.

From 1584610844098961959@xxx Mon Nov 20 18:31:03 +0000 2017
X-GM-THRID: 1584609371012247455
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread

2017-11-20 18:31:03

by Bjørn Mork

[permalink] [raw]
Subject: Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

Sebastian Sjoholm <[email protected]> writes:

> Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both
> CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development
> board (EVB). The USB id is added to qmi_wwan.c to allow QMI
> communication with the BG96.
>
> Signed-off-by: Sebastian Sjoholm <[email protected]>

Perfect. Thanks.

Acked-by: Bjørn Mork <[email protected]>

From 1584609371012247455@xxx Mon Nov 20 18:07:38 +0000 2017
X-GM-THRID: 1584609371012247455
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread