2008-02-13 21:05:31

by Brice Goglin

Subject: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

[I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

No need to compute copy twice in the frags loop in
dma_skb_copy_datagram_iovec().

Signed-off-by: Brice Goglin <[email protected]>
---
user_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/user_dma.c b/net/core/user_dma.c
index 0ad1cd5..c77aff9 100644
--- a/net/core/user_dma.c
+++ b/net/core/user_dma.c
@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan,

end = start + skb_shinfo(skb)->frags[i].size;
copy = end - offset;
- if ((copy = end - offset) > 0) {
+ if (copy > 0) {
skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
struct page *page = frag->page;

2008-02-14 01:03:01

by Dan Williams

Subject: Re: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

On Feb 13, 2008 2:05 PM, Brice Goglin <[email protected]> wrote:
> [I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec
>
> No need to compute copy twice in the frags loop in
> dma_skb_copy_datagram_iovec().
>
> Signed-off-by: Brice Goglin <[email protected]>

Thanks, I'll push this along.

--
Dan

2008-02-14 02:38:18

by Shannon Nelson

Subject: RE: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

>-----Original Message-----
>From: Brice Goglin [mailto:[email protected]]
>Sent: Wednesday, February 13, 2008 1:05 PM
>To: Nelson, Shannon; Williams, Dan J
>Cc: Leech, Christopher; LKML
>Subject: [PATCH][I/OAT]: Remove duplicate assignation in
>dma_skb_copy_datagram_iovec
>
>[I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec
>
>No need to compute copy twice in the frags loop in
>dma_skb_copy_datagram_iovec().
>
>Signed-off-by: Brice Goglin <[email protected]>
>---
> user_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/net/core/user_dma.c b/net/core/user_dma.c
>index 0ad1cd5..c77aff9 100644
>--- a/net/core/user_dma.c
>+++ b/net/core/user_dma.c
>@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct
>dma_chan *chan,
>
> end = start + skb_shinfo(skb)->frags[i].size;
> copy = end - offset;
>- if ((copy = end - offset) > 0) {
>+ if (copy > 0) {
> skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
> struct page *page = frag->page;
>

Acked-by: Shannon Nelson <[email protected]>