2011-06-10 07:51:58

by Kamezawa Hiroyuki

Subject: [BUGFIX][PATCH] fix memory.numa_stat file permission

I'm sorry I missed this bug because I tested as 'root' ...

=
>From 9fe15b548430635d4bbdc2b39e778dbb08e369c9 Mon Sep 17 00:00:00 2001
From: KAMEZAWA Hiroyuki <[email protected]>
Date: Fri, 10 Jun 2011 16:50:39 +0900
Subject: [PATCH][BUGFIX] memcg: fix memory.numa_stat file permission


commit 406eb0c9ba765eb066406fd5ce9d5e2b169a4d5a adds memory.numa_stat
file for memory cgroup. But it's file permission is wrong.

[kamezawa@bluextal linux-2.6]$ ls -l /cgroup/memory/A/memory.numa_stat
---------- 1 root root 0 Jun 9 18:36 /cgroup/memory/A/memory.numa_stat

This patch fixes the permission as

[root@bluextal kamezawa]# ls -l /cgroup/memory/A/memory.numa_stat
-r--r--r-- 1 root root 0 Jun 10 16:49 /cgroup/memory/A/memory.numa_stat

Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>
---
mm/memcontrol.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index bd9052a..ce05835 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4640,6 +4640,7 @@ static struct cftype mem_cgroup_files[] = {
{
.name = "numa_stat",
.open = mem_control_numa_stat_open,
+ .mode = S_IRUGO,
},
#endif
};
--
1.7.4.1

2011-06-10 16:47:10

by Ying Han

Subject: Re: [BUGFIX][PATCH] fix memory.numa_stat file permission

On Fri, Jun 10, 2011 at 12:44 AM, KAMEZAWA Hiroyuki
<[email protected]> wrote:
> I'm sorry I missed this bug because I tested as 'root' ...
>
> =
> From 9fe15b548430635d4bbdc2b39e778dbb08e369c9 Mon Sep 17 00:00:00 2001
> From: KAMEZAWA Hiroyuki <[email protected]>
> Date: Fri, 10 Jun 2011 16:50:39 +0900
> Subject: [PATCH][BUGFIX] memcg: fix memory.numa_stat file permission
>
>
> ?commit 406eb0c9ba765eb066406fd5ce9d5e2b169a4d5a adds memory.numa_stat
> ?file for memory cgroup. But it's file permission is wrong.
>
> [kamezawa@bluextal linux-2.6]$ ls -l /cgroup/memory/A/memory.numa_stat
> ---------- 1 root root 0 Jun ?9 18:36 /cgroup/memory/A/memory.numa_stat
>
> This patch fixes the permission as
>
> [root@bluextal kamezawa]# ls -l /cgroup/memory/A/memory.numa_stat
> -r--r--r-- 1 root root 0 Jun 10 16:49 /cgroup/memory/A/memory.numa_stat
>
> Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>
> ---
> ?mm/memcontrol.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index bd9052a..ce05835 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -4640,6 +4640,7 @@ static struct cftype mem_cgroup_files[] = {
> ? ? ? ?{
> ? ? ? ? ? ? ? ?.name = "numa_stat",
> ? ? ? ? ? ? ? ?.open = mem_control_numa_stat_open,
> + ? ? ? ? ? ? ? .mode = S_IRUGO,
> ? ? ? ?},
> ?#endif
> ?};
> --
> 1.7.4.1
>
>
>

Acked-by: Ying Han <[email protected]>

--Ying