2011-06-06 19:07:56

by anish singh

Subject: [PATCH 2/2] staging: iio added missing "()" in kmalloc

From: anish kumar <[email protected]>

"()" was missing from kmalloc,so added it.

Signed-off-by: anish kumar <[email protected]>
---
drivers/staging/iio/industrialio-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
index 3a82414..5251332 100644
--- a/drivers/staging/iio/industrialio-core.c
+++ b/drivers/staging/iio/industrialio-core.c
@@ -136,7 +136,7 @@ static irqreturn_t iio_interrupt_handler(int irq, void *_int_info)

static struct iio_interrupt *iio_allocate_interrupt(void)
{
- struct iio_interrupt *i = kmalloc(sizeof *i, GFP_KERNEL);
+ struct iio_interrupt *i = kmalloc(sizeof(*i), GFP_KERNEL);
if (i) {
spin_lock_init(&i->ev_list_lock);
INIT_LIST_HEAD(&i->ev_list);
--
1.7.0.4

2011-06-06 19:42:39

by Arnaud Lacombe

Subject: Re: [PATCH 2/2] staging: iio added missing "()" in kmalloc

Hi,

On Mon, Jun 6, 2011 at 3:07 PM, anish <[email protected]> wrote:
> From: anish kumar <[email protected]>
>
> "()" was missing from kmalloc,so added it.
>
This is not required per-se, is it fixing a bug of some sort ?

- Arnaud

> Signed-off-by: anish kumar <[email protected]>
> ---
> ?drivers/staging/iio/industrialio-core.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
> index 3a82414..5251332 100644
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -136,7 +136,7 @@ static irqreturn_t iio_interrupt_handler(int irq, void *_int_info)
>
> ?static struct iio_interrupt *iio_allocate_interrupt(void)
> ?{
> - ? ? ? struct iio_interrupt *i = kmalloc(sizeof *i, GFP_KERNEL);
> + ? ? ? struct iio_interrupt *i = kmalloc(sizeof(*i), GFP_KERNEL);
> ? ? ? ?if (i) {
> ? ? ? ? ? ? ? ?spin_lock_init(&i->ev_list_lock);
> ? ? ? ? ? ? ? ?INIT_LIST_HEAD(&i->ev_list);
> --
> 1.7.0.4
>
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at ?http://www.tux.org/lkml/
>