2011-06-07 21:44:15

by Fengguang Wu

[permalink] [raw]
Subject: [PATCH 00/15] writeback fixes and cleanups for 3.0 (v5)


Andrew,

Here are the intented patches for upstream submission, rebased to v3.0-rc2:

[PATCH 01/15] writeback: introduce .tagged_writepages for the WB_SYNC_NONE sync stage
[PATCH 02/15] writeback: update dirtied_when for synced inode to prevent livelock
[PATCH 03/15] writeback: introduce writeback_control.inodes_cleaned
[PATCH 04/15] writeback: try more writeback as long as something was written
[PATCH 05/15] writeback: the kupdate expire timestamp should be a moving target
[PATCH 06/15] writeback: refill b_io iff empty
[PATCH 07/15] writeback: split inode_wb_list_lock into bdi_writeback.list_lock
[PATCH 08/15] writeback: elevate queue_io() into wb_writeback()
[PATCH 09/15] writeback: avoid extra sync work at enqueue time
[PATCH 10/15] writeback: add bdi_dirty_limit() kernel-doc
[PATCH 11/15] writeback: skip balance_dirty_pages() for in-memory fs
[PATCH 12/15] writeback: remove writeback_control.more_io
[PATCH 13/15] writeback: remove .nonblocking and .encountered_congestion
[PATCH 14/15] writeback: trace event writeback_single_inode
[PATCH 15/15] writeback: trace event writeback_queue_io

fs/block_dev.c | 16 ++-
fs/ext4/inode.c | 4 +-
fs/fs-writeback.c | 219 ++++++++++++++++++++------------------
fs/inode.c | 5 +-
fs/nfs/write.c | 3 +-
fs/xfs/linux-2.6/xfs_aops.c | 2 +-
include/linux/backing-dev.h | 2 +
include/linux/writeback.h | 10 +--
include/trace/events/btrfs.h | 6 +-
include/trace/events/ext4.h | 6 +-
include/trace/events/writeback.h | 100 +++++++++++++++++-
mm/backing-dev.c | 21 +++-
mm/filemap.c | 6 +-
mm/page-writeback.c | 25 +++--
mm/rmap.c | 4 +-
15 files changed, 270 insertions(+), 159 deletions(-)

They are git pullable from

git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git fs-writeback

Thanks to Jan and Dave for the careful reviews!

Thanks,
Fengguang


2011-06-07 23:05:49

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 00/15] writeback fixes and cleanups for 3.0 (v5)

On Wed, 08 Jun 2011 05:32:36 +0800
Wu Fengguang <[email protected]> wrote:

>
> Andrew,
>
> Here are the intented patches for upstream submission, rebased to v3.0-rc2:
>
> [PATCH 01/15] writeback: introduce .tagged_writepages for the WB_SYNC_NONE sync stage
> [PATCH 02/15] writeback: update dirtied_when for synced inode to prevent livelock
> [PATCH 03/15] writeback: introduce writeback_control.inodes_cleaned
> [PATCH 04/15] writeback: try more writeback as long as something was written
> [PATCH 05/15] writeback: the kupdate expire timestamp should be a moving target
> [PATCH 06/15] writeback: refill b_io iff empty
> [PATCH 07/15] writeback: split inode_wb_list_lock into bdi_writeback.list_lock
> [PATCH 08/15] writeback: elevate queue_io() into wb_writeback()
> [PATCH 09/15] writeback: avoid extra sync work at enqueue time
> [PATCH 10/15] writeback: add bdi_dirty_limit() kernel-doc
> [PATCH 11/15] writeback: skip balance_dirty_pages() for in-memory fs
> [PATCH 12/15] writeback: remove writeback_control.more_io
> [PATCH 13/15] writeback: remove .nonblocking and .encountered_congestion
> [PATCH 14/15] writeback: trace event writeback_single_inode
> [PATCH 15/15] writeback: trace event writeback_queue_io

Looks OK to me, although I think a few of the changelogs are lacking
important details.

> They are git pullable from
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git fs-writeback
>

Please ask Stephen to suck this into linux-next when ready.

2011-06-08 02:01:08

by Fengguang Wu

[permalink] [raw]
Subject: Re: [PATCH 00/15] writeback fixes and cleanups for 3.0 (v5)

On Wed, Jun 08, 2011 at 07:04:41AM +0800, Andrew Morton wrote:
> On Wed, 08 Jun 2011 05:32:36 +0800
> Wu Fengguang <[email protected]> wrote:
>
> >
> > Andrew,
> >
> > Here are the intented patches for upstream submission, rebased to v3.0-rc2:
> >
> > [PATCH 01/15] writeback: introduce .tagged_writepages for the WB_SYNC_NONE sync stage
> > [PATCH 02/15] writeback: update dirtied_when for synced inode to prevent livelock
> > [PATCH 03/15] writeback: introduce writeback_control.inodes_cleaned
> > [PATCH 04/15] writeback: try more writeback as long as something was written
> > [PATCH 05/15] writeback: the kupdate expire timestamp should be a moving target
> > [PATCH 06/15] writeback: refill b_io iff empty
> > [PATCH 07/15] writeback: split inode_wb_list_lock into bdi_writeback.list_lock
> > [PATCH 08/15] writeback: elevate queue_io() into wb_writeback()
> > [PATCH 09/15] writeback: avoid extra sync work at enqueue time
> > [PATCH 10/15] writeback: add bdi_dirty_limit() kernel-doc
> > [PATCH 11/15] writeback: skip balance_dirty_pages() for in-memory fs
> > [PATCH 12/15] writeback: remove writeback_control.more_io
> > [PATCH 13/15] writeback: remove .nonblocking and .encountered_congestion
> > [PATCH 14/15] writeback: trace event writeback_single_inode
> > [PATCH 15/15] writeback: trace event writeback_queue_io
>
> Looks OK to me, although I think a few of the changelogs are lacking
> important details.

Thanks.

> > They are git pullable from
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git fs-writeback
> >
>
> Please ask Stephen to suck this into linux-next when ready.

OK, now it includes the updated patches. It's based on v3.0-rc2 and
also compile/runs OK with 3.0.0-rc2-next-20110607.

Stephen, would you help add this git branch to linux-next? Thank you.

git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git#fs-writeback

Thanks,
Fengguang

2011-06-08 06:21:54

by Sedat Dilek

[permalink] [raw]
Subject: Re: [PATCH 00/15] writeback fixes and cleanups for 3.0 (v5)

On Wed, Jun 8, 2011 at 4:01 AM, Wu Fengguang <[email protected]> wrote:
> On Wed, Jun 08, 2011 at 07:04:41AM +0800, Andrew Morton wrote:
>> On Wed, 08 Jun 2011 05:32:36 +0800
>> Wu Fengguang <[email protected]> wrote:
>>
>> >
>> > Andrew,
>> >
>> > Here are the intented patches for upstream submission, rebased to v3.0-rc2:
>> >
>> >     [PATCH 01/15] writeback: introduce .tagged_writepages for the WB_SYNC_NONE sync stage
>> >     [PATCH 02/15] writeback: update dirtied_when for synced inode to prevent livelock
>> >     [PATCH 03/15] writeback: introduce writeback_control.inodes_cleaned
>> >     [PATCH 04/15] writeback: try more writeback as long as something was written
>> >     [PATCH 05/15] writeback: the kupdate expire timestamp should be a moving target
>> >     [PATCH 06/15] writeback: refill b_io iff empty
>> >     [PATCH 07/15] writeback: split inode_wb_list_lock into bdi_writeback.list_lock
>> >     [PATCH 08/15] writeback: elevate queue_io() into wb_writeback()
>> >     [PATCH 09/15] writeback: avoid extra sync work at enqueue time
>> >     [PATCH 10/15] writeback: add bdi_dirty_limit() kernel-doc
>> >     [PATCH 11/15] writeback: skip balance_dirty_pages() for in-memory fs
>> >     [PATCH 12/15] writeback: remove writeback_control.more_io
>> >     [PATCH 13/15] writeback: remove .nonblocking and .encountered_congestion
>> >     [PATCH 14/15] writeback: trace event writeback_single_inode
>> >     [PATCH 15/15] writeback: trace event writeback_queue_io
>>
>> Looks OK to me, although I think a few of the changelogs are lacking
>> important details.
>
> Thanks.
>
>> > They are git pullable from
>> >
>> > git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git fs-writeback
>> >
>>
>> Please ask Stephen to suck this into linux-next when ready.
>
> OK, now it includes the updated patches. It's based on v3.0-rc2 and
> also compile/runs OK with 3.0.0-rc2-next-20110607.
>

So, did I a few hours ago... Running a kernel with your patchset
applied right now.

- Sedat -

> Stephen, would you help add this git branch to linux-next? Thank you.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git#fs-writeback
>
> Thanks,
> Fengguang
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

2011-06-08 13:45:22

by Fengguang Wu

[permalink] [raw]
Subject: Re: [PATCH 00/15] writeback fixes and cleanups for 3.0 (v5)

Hi Stephen,

> git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git#fs-writeback

Will you include this branch instead? It looks more reasonable as
suggested by Sedat:

git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git next

Thanks,
Fengguang

2011-06-09 01:16:22

by Stephen Rothwell

[permalink] [raw]
Subject: Re: [PATCH 00/15] writeback fixes and cleanups for 3.0 (v5)

Hi,

On Wed, 8 Jun 2011 21:45:10 +0800 Wu Fengguang <[email protected]> wrote:
>
> > git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git#fs-writeback
>
> Will you include this branch instead? It looks more reasonable as
> suggested by Sedat:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git next

I have added that tree starting today with just you as the contact
(please let me know if others should be added as contacts as well).

Thanks for adding your subsystem tree as a participant of linux-next. As
you may know, this is not a judgment of your code. The purpose of
linux-next is for integration testing and to lower the impact of
conflicts between subsystems in the next merge window.

You will need to ensure that the patches/commits in your tree/series have
been:
* submitted under GPL v2 (or later) and include the Contributor's
Signed-off-by,
* posted to the relevant mailing list,
* reviewed by you (or another maintainer of your subsystem tree),
* successfully unit tested, and
* destined for the current or next Linux merge window.

Basically, this should be just what you would send to Linus (or ask him
to fetch). It is allowed to be rebased if you deem it necessary.

--
Cheers,
Stephen Rothwell
[email protected]

Legal Stuff:
By participating in linux-next, your subsystem tree contributions are
public and will be included in the linux-next trees. You may be sent
e-mail messages indicating errors or other issues when the
patches/commits from your subsystem tree are merged and tested in
linux-next. These messages may also be cross-posted to the linux-next
mailing list, the linux-kernel mailing list, etc. The linux-next tree
project and IBM (my employer) make no warranties regarding the linux-next
project, the testing procedures, the results, the e-mails, etc. If you
don't agree to these ground rules, let me know and I'll remove your tree
from participation in linux-next.


Attachments:
(No filename) (1.93 kB)
(No filename) (490.00 B)
Download all attachments

2011-06-09 02:18:33

by Fengguang Wu

[permalink] [raw]
Subject: Re: [PATCH 00/15] writeback fixes and cleanups for 3.0 (v5)

Hi Stephen,

On Thu, Jun 09, 2011 at 09:16:09AM +0800, Stephen Rothwell wrote:
> Hi,
>
> On Wed, 8 Jun 2011 21:45:10 +0800 Wu Fengguang <[email protected]> wrote:
> >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git#fs-writeback
> >
> > Will you include this branch instead? It looks more reasonable as
> > suggested by Sedat:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git next
>
> I have added that tree starting today with just you as the contact
> (please let me know if others should be added as contacts as well).

Thank you!

> Thanks for adding your subsystem tree as a participant of linux-next. As
> you may know, this is not a judgment of your code. The purpose of
> linux-next is for integration testing and to lower the impact of
> conflicts between subsystems in the next merge window.
>
> You will need to ensure that the patches/commits in your tree/series have
> been:
> * submitted under GPL v2 (or later) and include the Contributor's
> Signed-off-by,
> * posted to the relevant mailing list,
> * reviewed by you (or another maintainer of your subsystem tree),
> * successfully unit tested, and
> * destined for the current or next Linux merge window.
>
> Basically, this should be just what you would send to Linus (or ask him
> to fetch). It is allowed to be rebased if you deem it necessary.

OK.

Thanks,
Fengguang