2011-06-13 11:51:20

by Konstantin Khlebnikov

Subject: [PATCH] efifb: fix device unregister on error path

Argument of platform_device_unregister() should be efifb_device, not efifb_driver.
bug in v3.0-rc1-57-gbb8b266

Signed-off-by: Konstantin Khlebnikov <[email protected]>
---
drivers/video/efifb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
index 69c49df..784139a 100644
--- a/drivers/video/efifb.c
+++ b/drivers/video/efifb.c
@@ -541,7 +541,7 @@ static int __init efifb_init(void)
*/
ret = platform_driver_probe(&efifb_driver, efifb_probe);
if (ret) {
- platform_device_unregister(&efifb_driver);
+ platform_device_unregister(&efifb_device);
return ret;
}

2011-06-13 13:33:31

by Maxin B. John

Subject: Re: [PATCH] efifb: fix device unregister on error path

Hi,

On Mon, Jun 13, 2011 at 12:51 PM, Konstantin Khlebnikov
<[email protected]> wrote:
> Argument of platform_device_unregister() should be efifb_device, not efifb_driver.
> bug in v3.0-rc1-57-gbb8b266
>
> Signed-off-by: Konstantin Khlebnikov <[email protected]>
> ---
> ?drivers/video/efifb.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
> index 69c49df..784139a 100644
> --- a/drivers/video/efifb.c
> +++ b/drivers/video/efifb.c
> @@ -541,7 +541,7 @@ static int __init efifb_init(void)
> ? ? ? ? */
> ? ? ? ?ret = platform_driver_probe(&efifb_driver, efifb_probe);
> ? ? ? ?if (ret) {
> - ? ? ? ? ? ? ? platform_device_unregister(&efifb_driver);
> + ? ? ? ? ? ? ? platform_device_unregister(&efifb_device);
> ? ? ? ? ? ? ? ?return ret;
> ? ? ? ?}

The same issue is present in this thread:

https://lkml.org/lkml/2011/6/12/34