2011-04-25 23:51:51

by Peter Foley

Subject: [PATCH] kbuild: fix sed error in export_report.pl

This patch fixes a sed error in export_report.pl by escaping a $.

Signed-off-by: Peter Foley <[email protected]>
---
scripts/export_report.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/export_report.pl b/scripts/export_report.pl
index 04dce7c..91fa5a2 100644
--- a/scripts/export_report.pl
+++ b/scripts/export_report.pl
@@ -50,7 +50,7 @@ sub usage {
sub collectcfiles {
my @file
- = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
+ = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko\$/.mod.c/`;
chomp @file;
return @file;
}
--
1.7.5.rc1

2011-04-26 06:40:06

by Arnaud Lacombe

Subject: Re: [PATCH] kbuild: fix sed error in export_report.pl

Hi,

On Mon, Apr 25, 2011 at 7:51 PM, Peter Foley <[email protected]> wrote:
> This patch fixes a sed error in export_report.pl by escaping a $.
>
Which error ?

Thanks,
- Arnaud

> Signed-off-by: Peter Foley <[email protected]>
> ---
> ?scripts/export_report.pl | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/export_report.pl b/scripts/export_report.pl
> index 04dce7c..91fa5a2 100644
> --- a/scripts/export_report.pl
> +++ b/scripts/export_report.pl
> @@ -50,7 +50,7 @@ sub usage {
> ?sub collectcfiles {
> ? ? my @file
> - ? ? ? = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
> + ? ? ? = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko\$/.mod.c/`;
> ? ? chomp @file;
> ? ? return @file;
> ?}
> --
> 1.7.5.rc1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>

2011-04-26 14:17:53

by Peter Foley

Subject: Re: [PATCH] kbuild: fix sed error in export_report.pl

On 4/26/2011 2:40 AM, Arnaud Lacombe wrote:
> Hi,
>
> On Mon, Apr 25, 2011 at 7:51 PM, Peter Foley <[email protected]> wrote:
>> This patch fixes a sed error in export_report.pl by escaping a $.
>>
> Which error ?
>
> Thanks,
> - Arnaud
>

This is the error I get:

make -C /usr/src/git O=/root/linux/t/. export_report
perl /usr/src/git/scripts/export_report.pl
sed: -e expression #1, char 5: unterminated `s' command
sh: line 1: .mod.c/: No such file or directory

2011-04-26 14:27:52

by Cong Wang

Subject: Re: [PATCH] kbuild: fix sed error in export_report.pl

On Tue, Apr 26, 2011 at 10:17 PM, Peter Foley <[email protected]> wrote:
> On 4/26/2011 2:40 AM, Arnaud Lacombe wrote:
>> Hi,
>>
>> On Mon, Apr 25, 2011 at 7:51 PM, Peter Foley <[email protected]> wrote:
>>> This patch fixes a sed error in export_report.pl by escaping a $.
>>>
>> Which error ?
>>
>> Thanks,
>>  - Arnaud
>>
>
> This is the error I get:
>
> make -C /usr/src/git O=/root/linux/t/. export_report
> perl /usr/src/git/scripts/export_report.pl
> sed: -e expression #1, char 5: unterminated `s' command
> sh: line 1: .mod.c/: No such file or directory

Please include this in your changelog.

But anyway,

Acked-by: WANG Cong <[email protected]>

Thanks!

2011-04-26 14:40:28

by Michal Marek

Subject: Re: [PATCH] kbuild: fix sed error in export_report.pl

On 26.4.2011 01:51, Peter Foley wrote:
> This patch fixes a sed error in export_report.pl by escaping a $.
>
> Signed-off-by: Peter Foley<[email protected]>
> ---
> scripts/export_report.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/export_report.pl b/scripts/export_report.pl
> index 04dce7c..91fa5a2 100644
> --- a/scripts/export_report.pl
> +++ b/scripts/export_report.pl
> @@ -50,7 +50,7 @@ sub usage {
> sub collectcfiles {
> my @file
> - = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
> + = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko\$/.mod.c/`;

Please enclose the argument in single quotes instead.

Michal

2011-04-26 21:11:34

by Peter Foley

Subject: Re: [PATCH] kbuild: fix sed error in export_report.pl

On 4/26/2011 10:40 AM, Michal Marek wrote:
> On 26.4.2011 01:51, Peter Foley wrote:
>> This patch fixes a sed error in export_report.pl by escaping a $.
>>
>> Signed-off-by: Peter Foley<[email protected]>
>> ---
>> scripts/export_report.pl | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/scripts/export_report.pl b/scripts/export_report.pl
>> index 04dce7c..91fa5a2 100644
>> --- a/scripts/export_report.pl
>> +++ b/scripts/export_report.pl
>> @@ -50,7 +50,7 @@ sub usage {
>> sub collectcfiles {
>> my @file
>> - = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
>> + = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed
>> s/\.ko\$/.mod.c/`;
>
> Please enclose the argument in single quotes instead.
>
> Michal

I tried doing that and still got:
perl /usr/src/git/scripts/export_report.pl
sed: -e expression #1, char 5: unterminated `s' command

Peter