From: Jean Pihet <[email protected]>
If used in a module both tracepoints need to be exported by the
kernel.
Fixed a typo in CONFIG_EVENT_POWER_TRACING_DEPRECATED to really
export the tracepoints.
Signed-off-by: Jean Pihet <[email protected]>
Cc: Thomas Renninger <[email protected]>
Cc: Ingo Molnar <[email protected]>
---
kernel/trace/power-traces.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/power-traces.c b/kernel/trace/power-traces.c
index f55fcf6..29b60f2 100644
--- a/kernel/trace/power-traces.c
+++ b/kernel/trace/power-traces.c
@@ -13,8 +13,9 @@
#define CREATE_TRACE_POINTS
#include <trace/events/power.h>
-#ifdef EVENT_POWER_TRACING_DEPRECATED
+#ifdef CONFIG_EVENT_POWER_TRACING_DEPRECATED
EXPORT_TRACEPOINT_SYMBOL_GPL(power_start);
+EXPORT_TRACEPOINT_SYMBOL_GPL(power_end);
#endif
EXPORT_TRACEPOINT_SYMBOL_GPL(cpu_idle);
--
1.7.1
* [email protected] <[email protected]> wrote:
> From: Jean Pihet <[email protected]>
>
> If used in a module both tracepoints need to be exported by the
> kernel.
but it's not used by any module in the kernel AFAICS, so why is this needed?
Thanks,
Ingo
Adding l-o and linux-pm MLs. The original post is at
http://www.spinics.net/lists/kernel/msg1186554.html
On Fri, May 13, 2011 at 4:48 PM, Ingo Molnar <[email protected]> wrote:
>
> * [email protected] <[email protected]> wrote:
>
>> From: Jean Pihet <[email protected]>
>>
>> If used in a module both tracepoints need to be exported by the
>> kernel.
>
> but it's not used by any module in the kernel AFAICS, so why is this needed?
Not currently, that is why the error went unnoticed. I think it is
better to fix it now than later.
I am working on a plan to clean-up and isolate the OMAP PM code from
the core code and to provide the PM functionality as a module. This
effort is part of the 'remove the crazy ARM churn' from the kernel.
Thanks,
Jean
>
> Thanks,
>
> ? ? ? ?Ingo
>
* Jean Pihet <[email protected]> wrote:
> Adding l-o and linux-pm MLs. The original post is at
> http://www.spinics.net/lists/kernel/msg1186554.html
>
> On Fri, May 13, 2011 at 4:48 PM, Ingo Molnar <[email protected]> wrote:
> >
> > * [email protected] <[email protected]> wrote:
> >
> >> From: Jean Pihet <[email protected]>
> >>
> >> If used in a module both tracepoints need to be exported by the
> >> kernel.
> >
> > but it's not used by any module in the kernel AFAICS, so why is this needed?
> Not currently, that is why the error went unnoticed. I think it is
> better to fix it now than later.
>
> I am working on a plan to clean-up and isolate the OMAP PM code from
> the core code and to provide the PM functionality as a module. This
> effort is part of the 'remove the crazy ARM churn' from the kernel.
Feel free to keep this patch with those modifications/cleanups:
Acked-by: Ingo Molnar <[email protected]>
but please make sure you push it together, i.e. never export something
(knowingly) without having in-tree use for it.
Thanks,
Ingo
On Mon, May 16, 2011 at 11:23 AM, Ingo Molnar <[email protected]> wrote:
>
> * Jean Pihet <[email protected]> wrote:
>
>> Adding l-o and linux-pm MLs. The original post is at
>> http://www.spinics.net/lists/kernel/msg1186554.html
>>
>> On Fri, May 13, 2011 at 4:48 PM, Ingo Molnar <[email protected]> wrote:
>> >
>> > * [email protected] <[email protected]> wrote:
>> >
>> >> From: Jean Pihet <[email protected]>
>> >>
>> >> If used in a module both tracepoints need to be exported by the
>> >> kernel.
>> >
>> > but it's not used by any module in the kernel AFAICS, so why is this needed?
>> Not currently, that is why the error went unnoticed. I think it is
>> better to fix it now than later.
>>
>> I am working on a plan to clean-up and isolate the OMAP PM code from
>> the core code and to provide the PM functionality as a module. This
>> effort is part of the 'remove the crazy ARM churn' from the kernel.
>
> Feel free to keep this patch with those modifications/cleanups:
>
> Acked-by: Ingo Molnar <[email protected]>
>
> but please make sure you push it together, i.e. never export something
> (knowingly) without having in-tree use for it.
Ok will push the changes together when they are ready.
>
> Thanks,
>
> ? ? ? ?Ingo
>
Thanks,
Jean