2011-05-01 22:10:34

by Thiago Farina

[permalink] [raw]
Subject: [PATCH] ide/ide-scan-pci.c: Use for_each_pci_dev().

Use for_each_pci_dev() to simplify the code.

Signed-off-by: Thiago Farina <[email protected]>
---
drivers/ide/ide-scan-pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ide-scan-pci.c b/drivers/ide/ide-scan-pci.c
index 0e79eff..c3da53e 100644
--- a/drivers/ide/ide-scan-pci.c
+++ b/drivers/ide/ide-scan-pci.c
@@ -88,7 +88,7 @@ static int __init ide_scan_pcibus(void)
struct list_head *l, *n;

pre_init = 0;
- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)))
+ for_each_pci_dev(dev)
ide_scan_pcidev(dev);

/*
--
1.7.5.rc2.5.g60e19


2011-05-10 22:57:16

by Thiago Farina

[permalink] [raw]
Subject: Re: [PATCH] ide/ide-scan-pci.c: Use for_each_pci_dev().

ping?

On Sun, May 1, 2011 at 7:10 PM, Thiago Farina <[email protected]> wrote:
> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Thiago Farina <[email protected]>
> ---
>  drivers/ide/ide-scan-pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ide/ide-scan-pci.c b/drivers/ide/ide-scan-pci.c
> index 0e79eff..c3da53e 100644
> --- a/drivers/ide/ide-scan-pci.c
> +++ b/drivers/ide/ide-scan-pci.c
> @@ -88,7 +88,7 @@ static int __init ide_scan_pcibus(void)
>        struct list_head *l, *n;
>
>        pre_init = 0;
> -       while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)))
> +       for_each_pci_dev(dev)
>                ide_scan_pcidev(dev);
>
>        /*
> --
> 1.7.5.rc2.5.g60e19
>
>

2011-05-16 21:25:38

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] ide/ide-scan-pci.c: Use for_each_pci_dev().

From: Thiago Farina <[email protected]>
Date: Sun, 1 May 2011 19:10:25 -0300

> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Thiago Farina <[email protected]>

Applied.