2011-05-23 13:54:51

by Steven Rostedt

Subject: [PATCH 3/6] ktest: Reboot to good kernel after every bisect run

From: Steven Rostedt <[email protected]>

Reboot after each bisect run regardless if the bisect passed
or failed. The test may just be to boot the kernel and that kernel
may not have a way to copy the next kerne to it. Reboot to a known
good kernel after each bisect run.

Signed-off-by: Steven Rostedt <[email protected]>
---
tools/testing/ktest/ktest.pl | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 0603e64..2011222 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -1248,14 +1248,14 @@ sub run_bisect_test {

if ($failed) {
$result = 0;
-
- # reboot the box to a good kernel
- if ($type ne "build") {
- bisect_reboot;
- }
} else {
$result = 1;
}
+
+ # reboot the box to a kernel we can ssh to
+ if ($type ne "build") {
+ bisect_reboot;
+ }
$in_bisect = 0;

return $result;
--
1.7.4.4

2011-05-23 15:04:20

by John Kacur

Subject: Re: [PATCH 3/6] ktest: Reboot to good kernel after every bisect run

On Mon, May 23, 2011 at 3:51 PM, Steven Rostedt <[email protected]> wrote:
> From: Steven Rostedt <[email protected]>
>
> Reboot after each bisect run regardless if the bisect passed
> or failed. The test may just be to boot the kernel and that kernel
> may not have a way to copy the next kerne to it. Reboot to a known
> good kernel after each bisect run.
>

How about an option to not reboot for good kernels?

2011-05-23 15:18:09

by Steven Rostedt

Subject: Re: [PATCH 3/6] ktest: Reboot to good kernel after every bisect run

On Mon, 2011-05-23 at 17:04 +0200, John Kacur wrote:
> On Mon, May 23, 2011 at 3:51 PM, Steven Rostedt <[email protected]> wrote:
> > From: Steven Rostedt <[email protected]>
> >
> > Reboot after each bisect run regardless if the bisect passed
> > or failed. The test may just be to boot the kernel and that kernel
> > may not have a way to copy the next kerne to it. Reboot to a known
> > good kernel after each bisect run.
> >
>
> How about an option to not reboot for good kernels?

Would be trivial to add. But that would be for 2.6.41.

Thanks,

-- Steve