2011-05-22 19:36:20

by Eduardo Silva

Subject: [PATCH] fs: add missing prefetch header to inode.c

inode.c fails in the compilation process due to the missing
include of linux/prefetch.h.

Signed-off-by: Eduardo Silva <[email protected]>
---
fs/inode.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/inode.c b/fs/inode.c
index 33c963d..c77081f 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -26,6 +26,7 @@
#include <linux/posix_acl.h>
#include <linux/ima.h>
#include <linux/cred.h>
+#include <linux/prefetch.h>
#include "internal.h"

/*
--
1.7.4.1

2011-05-22 19:51:27

by Richard Weinberger

Subject: Re: [PATCH] fs: add missing prefetch header to inode.c

On Sun, May 22, 2011 at 9:34 PM, Eduardo Silva <[email protected]> wrote:
> inode.c fails in the compilation process due to the missing
> include of linux/prefetch.h.

On which arch?
So far I've observed this build error only on UML.
A fix has already been submitted.

--
Thanks,
//richard

2011-05-22 20:04:45

by Sedat Dilek

Subject: Re: [PATCH] fs: add missing prefetch header to inode.c

On Sun, May 22, 2011 at 9:34 PM, Eduardo Silva <[email protected]> wrote:
> inode.c fails in the compilation process due to the missing
> include of linux/prefetch.h.
>
> Signed-off-by: Eduardo Silva <[email protected]>
> ---
>  fs/inode.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/inode.c b/fs/inode.c
> index 33c963d..c77081f 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -26,6 +26,7 @@
>  #include <linux/posix_acl.h>
>  #include <linux/ima.h>
>  #include <linux/cred.h>
> +#include <linux/prefetch.h>
>  #include "internal.h"
>
>  /*
> --
> 1.7.4.1
>

Just FYI:
"fs: add missing prefetch.h include" is in Linus tree [1].

- Sedat -

[1] http://git.us.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9ce6e0be0626a5de2aca8b769a4aa57086257156

2011-05-22 20:09:03

by Eduardo Silva

Subject: Re: [PATCH] fs: add missing prefetch header to inode.c

oh, yep, it was in UM arch :)

On Sun, May 22, 2011 at 4:04 PM, Sedat Dilek <[email protected]> wrote:
> On Sun, May 22, 2011 at 9:34 PM, Eduardo Silva <[email protected]> wrote:
>> inode.c fails in the compilation process due to the missing
>> include of linux/prefetch.h.
>>
>> Signed-off-by: Eduardo Silva <[email protected]>
>> ---
>> ?fs/inode.c | ? ?1 +
>> ?1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/inode.c b/fs/inode.c
>> index 33c963d..c77081f 100644
>> --- a/fs/inode.c
>> +++ b/fs/inode.c
>> @@ -26,6 +26,7 @@
>> ?#include <linux/posix_acl.h>
>> ?#include <linux/ima.h>
>> ?#include <linux/cred.h>
>> +#include <linux/prefetch.h>
>> ?#include "internal.h"
>>
>> ?/*
>> --
>> 1.7.4.1
>>
>
> Just FYI:
> "fs: add missing prefetch.h include" is in Linus tree [1].
>
> - Sedat -
>
> [1] http://git.us.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9ce6e0be0626a5de2aca8b769a4aa57086257156
>



--
Eduardo Silva
http://edsiper.linuxchile.cl
http://www.monkey-project.com

2011-05-22 20:13:21

by Richard Weinberger

Subject: Re: [PATCH] fs: add missing prefetch header to inode.c

On Sun, May 22, 2011 at 10:08 PM, Eduardo Silva <[email protected]> wrote:
> oh, yep, it was in UM arch :)

I've already submitted a patch for UML.
fs/inode.c is not the only place which needs the prefetch stuff...

--
Thanks,
//richard