2006-11-14 18:52:57

by Burman Yan

[permalink] [raw]
Subject: [PATCH 2.6.19-rc5] hwmon: HP Mobile data protection system 3D driver version 0.5

Hi.

I took into account previous remarks, so here is the new version of the
driver
for the accelerometer present in HP nc6400 laptops. See documentation in the
patch
for complete feature list. At this point I don't think there is anything
more that can
be added to this driver and also it works stable for me no matter how I
tried to abuse it.

Regards
Yan Burman

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/


Attachments:
mdps-0.5.patch (23.67 kB)

2006-11-14 20:17:04

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH 2.6.19-rc5] hwmon: HP Mobile data protection system 3D driver version 0.5

On 11/14/06, Burman Yan <[email protected]> wrote:
> Hi.
>
> I took into account previous remarks, so here is the new version of the
> driver
> for the accelerometer present in HP nc6400 laptops. See documentation in the
> patch
> for complete feature list. At this point I don't think there is anything
> more that can
> be added to this driver and also it works stable for me no matter how I
> tried to abuse it.
>

Hi,

I don't think that you need a spinlock to protect mdps.count. Just
make it atomic_t and use atomic_xchg(&mdps.count, 0) in
mdaps_misc_read to get and reset it.

Also why are you settng EV_KEY bit on the input device? You are not
reporintg any key events...

--
Dmitry