2010-01-29 10:19:33

by Roel Kluin

Subject: [PATCH] qla2xxx: negative error return in qla2x00_change_queue_depth()

The *change_queue_depth functions usually return a negative error return.

Signed-off-by: Roel Kluin <[email protected]>
---
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 8529eb1..0753877 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1258,7 +1258,7 @@ qla2x00_change_queue_depth(struct scsi_device *sdev, int qdepth, int reason)
qla2x00_adjust_sdev_qdepth_up(sdev, qdepth);
break;
default:
- return EOPNOTSUPP;
+ return -EOPNOTSUPP;
}

return sdev->queue_depth;

2010-02-02 19:47:52

by Giridhar Malavali

Subject: Re: [PATCH] qla2xxx: negative error return in qla2x00_change_queue_depth()

Acked-by: Giridhar Malavali <[email protected]>

On Jan 29, 2010, at 2:25 AM, Roel Kluin wrote:

> The *change_queue_depth functions usually return a negative error
> return.
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/
> qla_os.c
> index 8529eb1..0753877 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -1258,7 +1258,7 @@ qla2x00_change_queue_depth(struct scsi_device
> *sdev, int qdepth, int reason)
> qla2x00_adjust_sdev_qdepth_up(sdev, qdepth);
> break;
> default:
> - return EOPNOTSUPP;
> + return -EOPNOTSUPP;
> }
>
> return sdev->queue_depth;