2019-05-16 12:20:31

by Mariusz Bialonczyk

Subject: [PATCH] w1: ds2408: Fix typo after 49695ac46861 (reset on output_write retry with readback)

Fix a typo in commit:
49695ac46861 w1: ds2408: reset on output_write retry with readback

Reported-by: Phil Elwell <[email protected]>
Cc: Jean-Francois Dagenais <[email protected]>
Signed-off-by: Mariusz Bialonczyk <[email protected]>
---
drivers/w1/slaves/w1_ds2408.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c
index 92e8f0755b9a..edf0bc98012c 100644
--- a/drivers/w1/slaves/w1_ds2408.c
+++ b/drivers/w1/slaves/w1_ds2408.c
@@ -138,7 +138,7 @@ static ssize_t status_control_read(struct file *filp, struct kobject *kobj,
W1_F29_REG_CONTROL_AND_STATUS, buf);
}

-#ifdef fCONFIG_W1_SLAVE_DS2408_READBACK
+#ifdef CONFIG_W1_SLAVE_DS2408_READBACK
static bool optional_read_back_valid(struct w1_slave *sl, u8 expected)
{
u8 w1_buf[3];
--
2.19.0.rc1

2019-05-16 13:11:09

by Jean-François Dagenais

Subject: Re: [PATCH] w1: ds2408: Fix typo after 49695ac46861 (reset on output_write retry with readback)

Yikes! Human after all...

> On May 16, 2019, at 08:01, Mariusz Bialonczyk <[email protected]> wrote:
>
> Fix a typo in commit:
> 49695ac46861 w1: ds2408: reset on output_write retry with readback
>
> Reported-by: Phil Elwell <[email protected]>
> Cc: Jean-Francois Dagenais <[email protected]>
> Signed-off-by: Mariusz Bialonczyk <[email protected]>
> ---
> drivers/w1/slaves/w1_ds2408.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c
> index 92e8f0755b9a..edf0bc98012c 100644
> --- a/drivers/w1/slaves/w1_ds2408.c
> +++ b/drivers/w1/slaves/w1_ds2408.c
> @@ -138,7 +138,7 @@ static ssize_t status_control_read(struct file *filp, struct kobject *kobj,
> W1_F29_REG_CONTROL_AND_STATUS, buf);
> }
>
> -#ifdef fCONFIG_W1_SLAVE_DS2408_READBACK
> +#ifdef CONFIG_W1_SLAVE_DS2408_READBACK
> static bool optional_read_back_valid(struct w1_slave *sl, u8 expected)
> {
> u8 w1_buf[3];
> --
> 2.19.0.rc1
>