2018-10-30 11:57:36

by Colin King

Subject: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs

From: Colin Ian King <[email protected]>

Trivial fix to clean up an indentation issue, remove tabs

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/char/tlclk.c | 84 ++++++++++++++++++++++----------------------
1 file changed, 42 insertions(+), 42 deletions(-)

diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
index 8eeb4190207d..a0f2c0506176 100644
--- a/drivers/char/tlclk.c
+++ b/drivers/char/tlclk.c
@@ -506,27 +506,27 @@ static ssize_t store_select_amcb2_transmit_clock(struct device *d,

val = (unsigned char)tmp;
spin_lock_irqsave(&event_lock, flags);
- if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
- SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
- SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
- } else if (val >= CLK_8_592MHz) {
- SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
- switch (val) {
- case CLK_8_592MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
- break;
- case CLK_11_184MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
- break;
- case CLK_34_368MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
- break;
- case CLK_44_736MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
- break;
- }
- } else
- SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
+ if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
+ SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
+ SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
+ } else if (val >= CLK_8_592MHz) {
+ SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
+ switch (val) {
+ case CLK_8_592MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
+ break;
+ case CLK_11_184MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
+ break;
+ case CLK_34_368MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
+ break;
+ case CLK_44_736MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
+ break;
+ }
+ } else
+ SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);

spin_unlock_irqrestore(&event_lock, flags);

@@ -548,27 +548,27 @@ static ssize_t store_select_amcb1_transmit_clock(struct device *d,

val = (unsigned char)tmp;
spin_lock_irqsave(&event_lock, flags);
- if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
- SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
- SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
- } else if (val >= CLK_8_592MHz) {
- SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
- switch (val) {
- case CLK_8_592MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
- break;
- case CLK_11_184MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
- break;
- case CLK_34_368MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
- break;
- case CLK_44_736MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
- break;
- }
- } else
- SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
+ if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
+ SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
+ SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
+ } else if (val >= CLK_8_592MHz) {
+ SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
+ switch (val) {
+ case CLK_8_592MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
+ break;
+ case CLK_11_184MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
+ break;
+ case CLK_34_368MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
+ break;
+ case CLK_44_736MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
+ break;
+ }
+ } else
+ SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
spin_unlock_irqrestore(&event_lock, flags);

return strnlen(buf, count);
--
2.19.1

2018-10-30 11:58:47

by Colin King

Subject: Re: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs

$SUBJECT should be:

tlclk: clean an indentation issue, remove extraneous tabs

On 30/10/2018 11:56, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Trivial fix to clean up an indentation issue, remove tabs
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/char/tlclk.c | 84 ++++++++++++++++++++++----------------------
> 1 file changed, 42 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
> index 8eeb4190207d..a0f2c0506176 100644
> --- a/drivers/char/tlclk.c
> +++ b/drivers/char/tlclk.c
> @@ -506,27 +506,27 @@ static ssize_t store_select_amcb2_transmit_clock(struct device *d,
>
> val = (unsigned char)tmp;
> spin_lock_irqsave(&event_lock, flags);
> - if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> - SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> - } else if (val >= CLK_8_592MHz) {
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> - switch (val) {
> - case CLK_8_592MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> - break;
> - case CLK_11_184MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> - break;
> - case CLK_34_368MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> - break;
> - case CLK_44_736MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> - break;
> - }
> - } else
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
> + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> + } else if (val >= CLK_8_592MHz) {
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> + switch (val) {
> + case CLK_8_592MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> + break;
> + case CLK_11_184MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> + break;
> + case CLK_34_368MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> + break;
> + case CLK_44_736MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> + break;
> + }
> + } else
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
>
> spin_unlock_irqrestore(&event_lock, flags);
>
> @@ -548,27 +548,27 @@ static ssize_t store_select_amcb1_transmit_clock(struct device *d,
>
> val = (unsigned char)tmp;
> spin_lock_irqsave(&event_lock, flags);
> - if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> - SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> - } else if (val >= CLK_8_592MHz) {
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> - switch (val) {
> - case CLK_8_592MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> - break;
> - case CLK_11_184MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> - break;
> - case CLK_34_368MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> - break;
> - case CLK_44_736MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> - break;
> - }
> - } else
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
> + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> + } else if (val >= CLK_8_592MHz) {
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> + switch (val) {
> + case CLK_8_592MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> + break;
> + case CLK_11_184MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> + break;
> + case CLK_34_368MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> + break;
> + case CLK_44_736MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> + break;
> + }
> + } else
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
> spin_unlock_irqrestore(&event_lock, flags);
>
> return strnlen(buf, count);
>

2018-10-30 15:42:06

by Gross, Mark

Subject: RE: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs

Looks cool to me.

Reviewed-by <[email protected]>

--mark

> -----Original Message-----
> From: Colin King [mailto:[email protected]]
> Sent: Tuesday, October 30, 2018 4:57 AM
> To: Gross, Mark <[email protected]>; Arnd Bergmann <[email protected]>;
> Greg Kroah-Hartman <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs
>
> From: Colin Ian King <[email protected]>
>
> Trivial fix to clean up an indentation issue, remove tabs
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/char/tlclk.c | 84 ++++++++++++++++++++++----------------------
> 1 file changed, 42 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c index
> 8eeb4190207d..a0f2c0506176 100644
> --- a/drivers/char/tlclk.c
> +++ b/drivers/char/tlclk.c
> @@ -506,27 +506,27 @@ static ssize_t
> store_select_amcb2_transmit_clock(struct device *d,
>
> val = (unsigned char)tmp;
> spin_lock_irqsave(&event_lock, flags);
> - if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> - SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> - } else if (val >= CLK_8_592MHz) {
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> - switch (val) {
> - case CLK_8_592MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> - break;
> - case CLK_11_184MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> - break;
> - case CLK_34_368MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> - break;
> - case CLK_44_736MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> - break;
> - }
> - } else
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
> + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> + } else if (val >= CLK_8_592MHz) {
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> + switch (val) {
> + case CLK_8_592MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> + break;
> + case CLK_11_184MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> + break;
> + case CLK_34_368MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> + break;
> + case CLK_44_736MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> + break;
> + }
> + } else
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
>
> spin_unlock_irqrestore(&event_lock, flags);
>
> @@ -548,27 +548,27 @@ static ssize_t
> store_select_amcb1_transmit_clock(struct device *d,
>
> val = (unsigned char)tmp;
> spin_lock_irqsave(&event_lock, flags);
> - if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> - SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> - } else if (val >= CLK_8_592MHz) {
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> - switch (val) {
> - case CLK_8_592MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> - break;
> - case CLK_11_184MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> - break;
> - case CLK_34_368MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> - break;
> - case CLK_44_736MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> - break;
> - }
> - } else
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
> + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> + } else if (val >= CLK_8_592MHz) {
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> + switch (val) {
> + case CLK_8_592MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> + break;
> + case CLK_11_184MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> + break;
> + case CLK_34_368MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> + break;
> + case CLK_44_736MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> + break;
> + }
> + } else
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
> spin_unlock_irqrestore(&event_lock, flags);
>
> return strnlen(buf, count);
> --
> 2.19.1

2018-10-31 18:06:21

by Joe Perches

Subject: Re: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs

On Tue, 2018-10-30 at 11:57 +0000, Colin Ian King wrote:
> $SUBJECT should be:
>
> tlclk: clean an indentation issue, remove extraneous tabs

Perhaps add missing braces for the last else uses as well?

> On 30/10/2018 11:56, Colin King wrote:
> > From: Colin Ian King <[email protected]>
[]
> > diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
[]
> > + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> > + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> > + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> > + } else if (val >= CLK_8_592MHz) {
> > + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> > + switch (val) {
> > + case CLK_8_592MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> > + break;
> > + case CLK_11_184MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> > + break;
> > + case CLK_34_368MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> > + break;
> > + case CLK_44_736MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);.
> > + break;
> > + }
> > + } else
> > + SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);

here.

> > @@ -548,27 +548,27 @@ static ssize_t store_select_amcb1_transmit_clock(struct device *d,
[]
> > + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> > + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> > + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> > + } else if (val >= CLK_8_592MHz) {
> > + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> > + switch (val) {
> > + case CLK_8_592MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> > + break;
> > + case CLK_11_184MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> > + break;
> > + case CLK_34_368MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> > + break;
> > + case CLK_44_736MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> > + break;
> > + }
> > + } else
> > + SET_PORT_BITS(TLCLK_REG3, 0xf8, val);

and here.