2009-12-28 16:59:08

by Hartley Sweeten

Subject: [PATCH] kernel/time/jiffies.c: local symbols should be static

The symbol 'clocksource_jiffies' is not exported and should be static.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: John Stultz <[email protected]>

---

diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
index 5404a84..36d2d83 100644
--- a/kernel/time/jiffies.c
+++ b/kernel/time/jiffies.c
@@ -55,7 +55,7 @@ static cycle_t jiffies_read(struct clocksource *cs)
return (cycle_t) jiffies;
}

-struct clocksource clocksource_jiffies = {
+static struct clocksource clocksource_jiffies = {
.name = "jiffies",
.rating = 1, /* lowest valid rating*/
.read = jiffies_read,

2010-01-04 23:43:19

by john stultz

Subject: Re: [PATCH] kernel/time/jiffies.c: local symbols should be static

On Mon, 2009-12-28 at 11:59 -0500, H Hartley Sweeten wrote:
> The symbol 'clocksource_jiffies' is not exported and should be static.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: John Stultz <[email protected]>

Yep, clocksource_jiffies has stopped being used elsewhere, so this can
be cleaned up.

Acked-by: John Stultz <[email protected]>

thanks
-john



> ---
>
> diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
> index 5404a84..36d2d83 100644
> --- a/kernel/time/jiffies.c
> +++ b/kernel/time/jiffies.c
> @@ -55,7 +55,7 @@ static cycle_t jiffies_read(struct clocksource *cs)
> return (cycle_t) jiffies;
> }
>
> -struct clocksource clocksource_jiffies = {
> +static struct clocksource clocksource_jiffies = {
> .name = "jiffies",
> .rating = 1, /* lowest valid rating*/
> .read = jiffies_read,