2009-12-28 22:43:16

by Hartley Sweeten

Subject: [PATCH] drivers/net/lib82596.c: use %pM to shown MAC address

Use the %pM kernel extension to display the MAC address.

The only difference in the output is that the MAC address is
shown in the usual colon-separated hex notation instead of
space-separated.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: David S. Miller <[email protected]>

---

diff --git a/drivers/net/lib82596.c b/drivers/net/lib82596.c
index b117f7f..b60efd4 100644
--- a/drivers/net/lib82596.c
+++ b/drivers/net/lib82596.c
@@ -1094,11 +1094,9 @@ static int __devinit i82596_probe(struct net_device *dev)
return i;
};

- DEB(DEB_PROBE, printk(KERN_INFO "%s: 82596 at %#3lx,",
- dev->name, dev->base_addr));
- for (i = 0; i < 6; i++)
- DEB(DEB_PROBE, printk(" %2.2X", dev->dev_addr[i]));
- DEB(DEB_PROBE, printk(" IRQ %d.\n", dev->irq));
+ DEB(DEB_PROBE, printk(KERN_INFO "%s: 82596 at %#3lx, %pM IRQ %d.\n",
+ dev->name, dev->base_addr, dev->dev_addr,
+ dev->irq));
DEB(DEB_INIT, printk(KERN_INFO
"%s: dma at 0x%p (%d bytes), lp->scb at 0x%p\n",
dev->name, dma, (int)sizeof(struct i596_dma),

2009-12-30 17:15:39

by David Miller

Subject: Re: [PATCH] drivers/net/lib82596.c: use %pM to shown MAC address

From: "H Hartley Sweeten" <[email protected]>
Date: Mon, 28 Dec 2009 17:43:17 -0500

> Use the %pM kernel extension to display the MAC address.
>
> The only difference in the output is that the MAC address is
> shown in the usual colon-separated hex notation instead of
> space-separated.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>

Applied.