2010-01-07 02:02:08

by Peter Huewe

Subject: [PATCH] mtd/nand: Fix build failure caused by typo

From: Peter Huewe <[email protected]>
Date: Thu, 7 Jan 2010 02:51:13 +0100

This patch fixes a build failure[1] introduced by the patch
mtd: orion_nand.c: add error handling and use resource_size()
by H Hartley Sweeten [2]
The patch assigns something to a undeclared variable 'err', whereas the
rest of the code uses 'ret' for this task.

This patch fixes this typo and thus removes the build failure.

References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/1983354/
[2] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=e99030609e27abff7e1a868cb56384c678b09984

Patch against linux-next of Do 7. Jan 02:58:41 CET 2010

Signed-off-by: Peter Huewe <[email protected]>
---
drivers/mtd/nand/orion_nand.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
index 9903460..f16050c 100644
--- a/drivers/mtd/nand/orion_nand.c
+++ b/drivers/mtd/nand/orion_nand.c
@@ -92,7 +92,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
- err = -ENODEV;
+ ret = -ENODEV;
goto no_res;
}

--
1.6.4.4

2010-01-07 02:16:39

by Hartley Sweeten

Subject: RE: [PATCH] mtd/nand: Fix build failure caused by typo

On Wednesday, January 06, 2010 7:02 PM, Peter H?we wrote:
> From: Peter Huewe <[email protected]>
> Date: Thu, 7 Jan 2010 02:51:13 +0100
>
> This patch fixes a build failure[1] introduced by the patch
> mtd: orion_nand.c: add error handling and use resource_size()
> by H Hartley Sweeten [2]
> The patch assigns something to a undeclared variable 'err', whereas the
> rest of the code uses 'ret' for this task.
>
> This patch fixes this typo and thus removes the build failure.
>
> References:
> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/1983354/
> [2] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=e99030609e27abff7e1a868cb56384c678b09984
>
> Patch against linux-next of Do 7. Jan 02:58:41 CET 2010
>
> Signed-off-by: Peter Huewe <[email protected]>
> ---
> drivers/mtd/nand/orion_nand.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
> index 9903460..f16050c 100644
> --- a/drivers/mtd/nand/orion_nand.c
> +++ b/drivers/mtd/nand/orion_nand.c
> @@ -92,7 +92,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res) {
> - err = -ENODEV;
> + ret = -ENODEV;
> goto no_res;
> }

Sorry about that.

Reviewed-by: H Hartley Sweeten <[email protected]>

2010-01-07 08:38:18

by Uwe Kleine-König

Subject: Re: [PATCH] mtd/nand: Fix build failure caused by typo

Hello,

> > This patch fixes a build failure[1] introduced by the patch
> > mtd: orion_nand.c: add error handling and use resource_size()
> > by H Hartley Sweeten [2]
> > The patch assigns something to a undeclared variable 'err', whereas the
> > rest of the code uses 'ret' for this task.
> >
> > This patch fixes this typo and thus removes the build failure.
Acked-by: Uwe Kleine-K?nig <[email protected]>

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |