2002-02-28 23:22:47

by Chris Leech

[permalink] [raw]
Subject: RE: hardware VLAN acceleration


> The group is still valid, groups are never destroyed by the VLAN layer
> once they are created.

Unless the 802.1q code is built as a module. It looks to me like if you
unregistered the virtual interface and unload the 802.1q module, if another
tagged packet is received tg3 will still call vlan_hwaccel_rx and deref
tp->vlgrp which now points to who knows what.

Chris

--
Chris Leech <[email protected]>
Network Software Engineer
UNIX/Linux/Netware Development Group
LAN Access Division, Intel


2002-02-28 23:27:00

by David Miller

[permalink] [raw]
Subject: Re: hardware VLAN acceleration

From: "Leech, Christopher" <[email protected]>
Date: Thu, 28 Feb 2002 15:17:54 -0800


> The group is still valid, groups are never destroyed by the VLAN layer
> once they are created.

Unless the 802.1q code is built as a module. It looks to me like if you
unregistered the virtual interface and unload the 802.1q module, if another
tagged packet is received tg3 will still call vlan_hwaccel_rx and deref
tp->vlgrp which now points to who knows what.

Any time VLAN groups exist, the VLAN module should not be unloadable.

This is a hokey area of how the VLAN layer works and I intend
to fix it.