Print more info when platform device suspend function failed.
Without this patch, we can not get the real platform device suspend
API info.
Example without this patch:
pm_op(): platform_pm_suspend+0x0/0x50 returns -11
PM: Device power.0 failed to suspend: error -11
And with this patch:
platform_pm_suspend(): power_suspend+0x0/0x30 returns -11
pm_op(): platform_pm_suspend+0x0/0x80 returns -11
PM: Device power.0 failed to suspend: error -11
Signed-off-by: liu chuansheng <[email protected]>
Signed-off-by: Li Fei <[email protected]>
---
drivers/base/platform.c | 19 +++++++++++++++----
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index c0b8df3..96a452a 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -747,8 +747,10 @@ static int platform_legacy_suspend(struct device *dev, pm_message_t mesg)
struct platform_device *pdev = to_platform_device(dev);
int ret = 0;
- if (dev->driver && pdrv->suspend)
+ if (dev->driver && pdrv->suspend) {
ret = pdrv->suspend(pdev, mesg);
+ suspend_report_result(pdrv->suspend, ret);
+ }
return ret;
}
@@ -778,10 +780,13 @@ int platform_pm_suspend(struct device *dev)
return 0;
if (drv->pm) {
- if (drv->pm->suspend)
+ if (drv->pm->suspend) {
ret = drv->pm->suspend(dev);
+ suspend_report_result(drv->pm->suspend, ret);
+ }
} else {
ret = platform_legacy_suspend(dev, PMSG_SUSPEND);
+ suspend_report_result(platform_legacy_suspend, ret);
}
return ret;
@@ -818,10 +823,13 @@ int platform_pm_freeze(struct device *dev)
return 0;
if (drv->pm) {
- if (drv->pm->freeze)
+ if (drv->pm->freeze) {
ret = drv->pm->freeze(dev);
+ suspend_report_result(drv->pm->freeze, ret);
+ }
} else {
ret = platform_legacy_suspend(dev, PMSG_FREEZE);
+ suspend_report_result(platform_legacy_suspend, ret);
}
return ret;
@@ -854,10 +862,13 @@ int platform_pm_poweroff(struct device *dev)
return 0;
if (drv->pm) {
- if (drv->pm->poweroff)
+ if (drv->pm->poweroff) {
ret = drv->pm->poweroff(dev);
+ suspend_report_result(drv->pm->poweroff, ret);
+ }
} else {
ret = platform_legacy_suspend(dev, PMSG_HIBERNATE);
+ suspend_report_result(platform_legacy_suspend, ret);
}
return ret;
--
1.7.4.1
On Mon, Mar 18, 2013 at 01:58:23PM +0800, Li Fei wrote:
>
> Print more info when platform device suspend function failed.
> Without this patch, we can not get the real platform device suspend
> API info.
>
> Example without this patch:
> pm_op(): platform_pm_suspend+0x0/0x50 returns -11
> PM: Device power.0 failed to suspend: error -11
>
> And with this patch:
> platform_pm_suspend(): power_suspend+0x0/0x30 returns -11
> pm_op(): platform_pm_suspend+0x0/0x80 returns -11
> PM: Device power.0 failed to suspend: error -11
How does that help someone out? One extra line? What is that going to
allow a user to now do?
greg k-h
> > Print more info when platform device suspend function failed.
> > Without this patch, we can not get the real platform device suspend
> > API info.
> >
> > Example without this patch:
> > pm_op(): platform_pm_suspend+0x0/0x50 returns -11
> > PM: Device power.0 failed to suspend: error -11
> >
> > And with this patch:
> > platform_pm_suspend(): power_suspend+0x0/0x30 returns -11
> > pm_op(): platform_pm_suspend+0x0/0x80 returns -11
> > PM: Device power.0 failed to suspend: error -11
>
> How does that help someone out? One extra line? What is that going to
> allow a user to now do?
>
Thanks for your comments.
The intention is to print relatively complete call path for convenience of
debugging in case of error. With this, we can know the exact name of
the concrete failed function.
Besides, currently such information is printed with level KERN_ERR,
and can be tuned through console_loglevel to avoid the possible impact
to end user.
Do you think it make sense?
Thanks and Regards,
Li Fei
> greg k-h
On Tue, Mar 19, 2013 at 02:05:02AM +0000, Li, Fei wrote:
> > > Print more info when platform device suspend function failed.
> > > Without this patch, we can not get the real platform device suspend
> > > API info.
> > >
> > > Example without this patch:
> > > pm_op(): platform_pm_suspend+0x0/0x50 returns -11
> > > PM: Device power.0 failed to suspend: error -11
> > >
> > > And with this patch:
> > > platform_pm_suspend(): power_suspend+0x0/0x30 returns -11
> > > pm_op(): platform_pm_suspend+0x0/0x80 returns -11
> > > PM: Device power.0 failed to suspend: error -11
> >
> > How does that help someone out? One extra line? What is that going to
> > allow a user to now do?
> >
> Thanks for your comments.
>
> The intention is to print relatively complete call path for convenience of
> debugging in case of error. With this, we can know the exact name of
> the concrete failed function.
And what was the failed function here, and what would that enable you to
do?
> Besides, currently such information is printed with level KERN_ERR,
> and can be tuned through console_loglevel to avoid the possible impact
> to end user.
Huh? End users see KERN_ERR.
> Do you think it make sense?
no. But this is Rafael's file, so I'll defer to him.
greg k-h