2001-07-26 16:17:35

by Leif Sawyer

[permalink] [raw]
Subject: RE: Sparc-64 kernel build fails on version.h during 'make oldconf ig'

Andreas Schwab <[email protected]> responded to:
> Thorsten Kukuk <[email protected]> who writes:
>
> |> No, I send you and on the sparclinux list already a patch for
> |> this 2 weeks ago. The problem is, that make dep will build at
> |> first sparc specific programs (archdep) which needs linux/version.h,
> |> but make dep does create linux/version.h only after building
> |> this tools. The following patch solved the problem for me:
> |>
> |> --- linux/Makefile
> |> +++ linux/Makefile 2001/05/21 12:57:07
> |> @@ -440,7 +440,7 @@
> |> sums:
> |> find . -type f -print | sort | xargs sum > .SUMS
> |>
> |> -dep-files: scripts/mkdep archdep include/linux/version.h
> |> +dep-files: include/linux/version.h scripts/mkdep archdep
>
> This will still fail with parallel builds. Better make the
> dependency of archdep on version.h explicit.

Hmm.. didn't think about SMP, as I'm only UP right now.

The enclosed patch then should cover all the architectures
for the stock 2.4.7 kernel.

I tried to find the cleanest place to put the dependancy,
which was usually on the archdep: target, but in the case
of sparc builds, it was on the check-asm: target.

In either case, i'm now building correctly for both i386 and sparc64
for make -j2 dep. I can also break out of the archdep tools build
and find version.h built, so unless anybody has any major gripes, this
patch should find it's way to the general release, yes?

Alan?


Attachments:
makefiles.diff (4.69 kB)

2001-07-27 09:42:40

by David Miller

[permalink] [raw]
Subject: RE: Sparc-64 kernel build fails on version.h during 'make oldconf ig'


Leif Sawyer writes:
> > |> -dep-files: scripts/mkdep archdep include/linux/version.h
> > |> +dep-files: include/linux/version.h scripts/mkdep archdep
> >
> > This will still fail with parallel builds. Better make the
> > dependency of archdep on version.h explicit.
>
> Hmm.. didn't think about SMP, as I'm only UP right now.
>
> The enclosed patch then should cover all the architectures
> for the stock 2.4.7 kernel.

Your patch points out that just making check_asm
depend on include/linux/version.h solves the problem
just fine too.

And this is the change I am making to my tree. I'd rather
keep the change localized to Sparc{,64} for 2.4.x

Thanks.

Later,
David S. Miller
[email protected]