2004-09-12 11:19:53

by Christoph Hellwig

Subject: [PATCH] superflous do_softirq invocation in cris do_IRQ()

irq_exit already does softirq processing, no need to do it a second
time.


--- 1.16/arch/cris/kernel/irq.c 2004-08-31 09:57:57 +02:00
+++ edited/arch/cris/kernel/irq.c 2004-09-11 21:21:15 +02:00
@@ -159,9 +159,6 @@
}
irq_exit();

- if (softirq_pending(cpu))
- do_softirq();
-
/* unmasking and bottom half handling is done magically for us. */
}

2004-09-13 06:01:12

by Mikael Starvik

Subject: RE: [PATCH] superflous do_softirq invocation in cris do_IRQ()

Great! That was a copy-paste from 2.4. Thanks for caring about CRIS!

/Mikael

-----Original Message-----
From: [email protected]
[mailto:[email protected]] On Behalf Of Christoph Hellwig
Sent: Sunday, September 12, 2004 1:20 PM
To: Bj?rn Wes?n
Cc: dev-etrax; [email protected]
Subject: [PATCH] superflous do_softirq invocation in cris do_IRQ()


irq_exit already does softirq processing, no need to do it a second
time.


--- 1.16/arch/cris/kernel/irq.c 2004-08-31 09:57:57 +02:00
+++ edited/arch/cris/kernel/irq.c 2004-09-11 21:21:15 +02:00
@@ -159,9 +159,6 @@
}
irq_exit();

- if (softirq_pending(cpu))
- do_softirq();
-
/* unmasking and bottom half handling is done magically for us. */
}