2003-05-23 08:25:22

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: [PATCH] Fix warning with ndelay


--
Benjamin Herrenschmidt <[email protected]>


2003-05-23 08:26:48

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: [PATCH] PPC32 Fix warning with ndelay (with patch !)

OOOps, here's the real one...

This patch fixes a warning with recent gcc's when using the new
ndelay() function, by properly defining a large constant as unsigned

===== include/asm-ppc/delay.h 1.5 vs edited =====
--- 1.5/include/asm-ppc/delay.h Wed Feb 12 05:29:33 2003
+++ edited/include/asm-ppc/delay.h Fri May 23 10:26:50 2003
@@ -30,8 +30,8 @@
* (which corresponds to ~3800 bogomips at HZ = 100).
* -- paulus
*/
-#define __MAX_UDELAY (226050910/HZ) /* maximum udelay argument */
-#define __MAX_NDELAY (4294967295/HZ) /* maximum ndelay argument */
+#define __MAX_UDELAY (226050910UL/HZ) /* maximum udelay argument */
+#define __MAX_NDELAY (4294967295UL/HZ) /* maximum ndelay argument */

extern __inline__ void __udelay(unsigned int x)
{

2003-05-23 08:55:21

by Riley Williams

[permalink] [raw]
Subject: RE: [PATCH] Fix warning with ndelay

Hi Benjamin.

Did you forget to enclose the patch?

Best wishes from Riley.
---
* Nothing as pretty as a smile, nothing as ugly as a frown.


> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]]On Behalf Of Benjamin
> Herrenschmidt
> Sent: Friday, May 23, 2003 9:38 AM
> To: Marcelo Tosatti
> Cc: Paul Mackerras; linux-kernel mailing list
> Subject: [PATCH] Fix warning with ndelay
>
>
>
> --
> Benjamin Herrenschmidt <[email protected]>
> -
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
> ---
> Incoming mail is certified Virus Free.
> Checked by AVG anti-virus system (http://www.grisoft.com).
> Version: 6.0.483 / Virus Database: 279 - Release Date: 19-May-2003
>
---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.483 / Virus Database: 279 - Release Date: 19-May-2003