2020-07-27 04:14:41

by Cao, Bingbu

Subject: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu

Fix the typo in email address of Tianshu Qiu and correct the name.

Signed-off-by: Bingbu Cao <[email protected]>
Signed-off-by: Tianshu Qiu <[email protected]>
Reported-by: Bjorn Helgaas <[email protected]>
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5392f00cec46..638dfa99751b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8765,7 +8765,7 @@ INTEL IPU3 CSI-2 CIO2 DRIVER
M: Yong Zhi <[email protected]>
M: Sakari Ailus <[email protected]>
M: Bingbu Cao <[email protected]>
-R: Tian Shu Qiu <[email protected]>
+R: Tianshu Qiu <[email protected]>
L: [email protected]
S: Maintained
F: Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst
@@ -8774,7 +8774,7 @@ F: drivers/media/pci/intel/ipu3/
INTEL IPU3 CSI-2 IMGU DRIVER
M: Sakari Ailus <[email protected]>
R: Bingbu Cao <[email protected]>
-R: Tian Shu Qiu <[email protected]>
+R: Tianshu Qiu <[email protected]>
L: [email protected]
S: Maintained
F: Documentation/admin-guide/media/ipu3.rst
@@ -12609,7 +12609,7 @@ T: git git://linuxtv.org/media_tree.git
F: drivers/media/i2c/ov2685.c

OMNIVISION OV2740 SENSOR DRIVER
-M: Tianshu Qiu <[email protected]>
+M: Tianshu Qiu <[email protected]>
R: Shawn Tu <[email protected]>
R: Bingbu Cao <[email protected]>
L: [email protected]
--
2.7.4

2020-07-27 04:21:29

by Qiu, Tian Shu

Subject: RE: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu

Reviewed-by: Tianshu Qiu <[email protected]>


> -----Original Message-----
> From: Cao, Bingbu <[email protected]>
> Sent: Monday, July 27, 2020 12:12 PM
> To: [email protected]; [email protected]; [email protected]
> Cc: [email protected]; Qiu, Tian Shu <[email protected]>; Cao, Bingbu <[email protected]>;
> [email protected]
> Subject: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu
>
> Fix the typo in email address of Tianshu Qiu and correct the name.
>
> Signed-off-by: Bingbu Cao <[email protected]>
> Signed-off-by: Tianshu Qiu <[email protected]>
> Reported-by: Bjorn Helgaas <[email protected]>
> ---
> MAINTAINERS | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5392f00cec46..638dfa99751b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8765,7 +8765,7 @@ INTEL IPU3 CSI-2 CIO2 DRIVER
> M: Yong Zhi <[email protected]>
> M: Sakari Ailus <[email protected]>
> M: Bingbu Cao <[email protected]>
> -R: Tian Shu Qiu <[email protected]>
> +R: Tianshu Qiu <[email protected]>
> L: [email protected]
> S: Maintained
> F: Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst
> @@ -8774,7 +8774,7 @@ F: drivers/media/pci/intel/ipu3/
> INTEL IPU3 CSI-2 IMGU DRIVER
> M: Sakari Ailus <[email protected]>
> R: Bingbu Cao <[email protected]>
> -R: Tian Shu Qiu <[email protected]>
> +R: Tianshu Qiu <[email protected]>
> L: [email protected]
> S: Maintained
> F: Documentation/admin-guide/media/ipu3.rst
> @@ -12609,7 +12609,7 @@ T: git git://linuxtv.org/media_tree.git
> F: drivers/media/i2c/ov2685.c
>
> OMNIVISION OV2740 SENSOR DRIVER
> -M: Tianshu Qiu <[email protected]>
> +M: Tianshu Qiu <[email protected]>
> R: Shawn Tu <[email protected]>
> R: Bingbu Cao <[email protected]>
> L: [email protected]
> --
> 2.7.4

2020-07-27 19:01:34

by Bjorn Helgaas

Subject: Re: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu

On Mon, Jul 27, 2020 at 04:20:39AM +0000, Qiu, Tian Shu wrote:
> Reviewed-by: Tianshu Qiu <[email protected]>

This doesn't really make sense. The patch already contains your
Signed-off-by, which means you participated in its development (see
Documentation/process/submitting-patches.rst), and I don't think it
makes sense to review your own patch.

> > -----Original Message-----
> > From: Cao, Bingbu <[email protected]>
> > Sent: Monday, July 27, 2020 12:12 PM
> > To: [email protected]; [email protected]; [email protected]
> > Cc: [email protected]; Qiu, Tian Shu <[email protected]>; Cao, Bingbu <[email protected]>;
> > [email protected]
> > Subject: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu
> >
> > Fix the typo in email address of Tianshu Qiu and correct the name.
> >
> > Signed-off-by: Bingbu Cao <[email protected]>
> > Signed-off-by: Tianshu Qiu <[email protected]>

Also, Documentation/process/submitting-patches.rst says "the last
Signed-off-by: must always be that of the developer submitting the
patch," which means these should be reversed, since Bingbu submitted
the patch.

> > Reported-by: Bjorn Helgaas <[email protected]>

I don't care whether you include this or not, but if you do, it would
typically go first, since the report comes before the writing of the
patch.

> > ---
> > MAINTAINERS | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5392f00cec46..638dfa99751b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -8765,7 +8765,7 @@ INTEL IPU3 CSI-2 CIO2 DRIVER
> > M: Yong Zhi <[email protected]>
> > M: Sakari Ailus <[email protected]>
> > M: Bingbu Cao <[email protected]>
> > -R: Tian Shu Qiu <[email protected]>
> > +R: Tianshu Qiu <[email protected]>
> > L: [email protected]
> > S: Maintained
> > F: Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst
> > @@ -8774,7 +8774,7 @@ F: drivers/media/pci/intel/ipu3/
> > INTEL IPU3 CSI-2 IMGU DRIVER
> > M: Sakari Ailus <[email protected]>
> > R: Bingbu Cao <[email protected]>
> > -R: Tian Shu Qiu <[email protected]>
> > +R: Tianshu Qiu <[email protected]>
> > L: [email protected]
> > S: Maintained
> > F: Documentation/admin-guide/media/ipu3.rst
> > @@ -12609,7 +12609,7 @@ T: git git://linuxtv.org/media_tree.git
> > F: drivers/media/i2c/ov2685.c
> >
> > OMNIVISION OV2740 SENSOR DRIVER
> > -M: Tianshu Qiu <[email protected]>
> > +M: Tianshu Qiu <[email protected]>
> > R: Shawn Tu <[email protected]>
> > R: Bingbu Cao <[email protected]>
> > L: [email protected]
> > --
> > 2.7.4
>

2020-07-28 13:10:46

by Qiu, Tian Shu

Subject: RE: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu

> -----Original Message-----
> From: Bjorn Helgaas <[email protected]>
> Sent: Tuesday, July 28, 2020 1:31 AM
> To: Qiu, Tian Shu <[email protected]>
> Cc: Cao, Bingbu <[email protected]>; [email protected]; [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu
>
> On Mon, Jul 27, 2020 at 04:20:39AM +0000, Qiu, Tian Shu wrote:
> > Reviewed-by: Tianshu Qiu <[email protected]>
>
> This doesn't really make sense. The patch already contains your
> Signed-off-by, which means you participated in its development (see
> Documentation/process/submitting-patches.rst), and I don't think it
> makes sense to review your own patch.

Thanks for pointing this out. Sorry I did not pay attention to this.

>
> > > -----Original Message-----
> > > From: Cao, Bingbu <[email protected]>
> > > Sent: Monday, July 27, 2020 12:12 PM
> > > To: [email protected]; [email protected]; [email protected]
> > > Cc: [email protected]; Qiu, Tian Shu <[email protected]>; Cao, Bingbu <[email protected]>;
> > > [email protected]
> > > Subject: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu
> > >
> > > Fix the typo in email address of Tianshu Qiu and correct the name.
> > >
> > > Signed-off-by: Bingbu Cao <[email protected]>
> > > Signed-off-by: Tianshu Qiu <[email protected]>
>
> Also, Documentation/process/submitting-patches.rst says "the last
> Signed-off-by: must always be that of the developer submitting the
> patch," which means these should be reversed, since Bingbu submitted
> the patch.
>
> > > Reported-by: Bjorn Helgaas <[email protected]>
>
> I don't care whether you include this or not, but if you do, it would
> typically go first, since the report comes before the writing of the
> patch.
>
> > > ---
> > > MAINTAINERS | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 5392f00cec46..638dfa99751b 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -8765,7 +8765,7 @@ INTEL IPU3 CSI-2 CIO2 DRIVER
> > > M: Yong Zhi <[email protected]>
> > > M: Sakari Ailus <[email protected]>
> > > M: Bingbu Cao <[email protected]>
> > > -R: Tian Shu Qiu <[email protected]>
> > > +R: Tianshu Qiu <[email protected]>
> > > L: [email protected]
> > > S: Maintained
> > > F: Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst
> > > @@ -8774,7 +8774,7 @@ F: drivers/media/pci/intel/ipu3/
> > > INTEL IPU3 CSI-2 IMGU DRIVER
> > > M: Sakari Ailus <[email protected]>
> > > R: Bingbu Cao <[email protected]>
> > > -R: Tian Shu Qiu <[email protected]>
> > > +R: Tianshu Qiu <[email protected]>
> > > L: [email protected]
> > > S: Maintained
> > > F: Documentation/admin-guide/media/ipu3.rst
> > > @@ -12609,7 +12609,7 @@ T: git git://linuxtv.org/media_tree.git
> > > F: drivers/media/i2c/ov2685.c
> > >
> > > OMNIVISION OV2740 SENSOR DRIVER
> > > -M: Tianshu Qiu <[email protected]>
> > > +M: Tianshu Qiu <[email protected]>
> > > R: Shawn Tu <[email protected]>
> > > R: Bingbu Cao <[email protected]>
> > > L: [email protected]
> > > --
> > > 2.7.4
> >