Add support for the 1080x2408 Truly NT36672E LCD DSI mode panel
found on the Qualcomm QCM6490 MTP board.
The driver will come with the uncompressed video mode support.
Ritesh Kumar (2):
dt-bindings: display: panel: Add Truly NT36672E LCD DSI panel
drm/panel: Add support for Truly NT36672E panel driver
.../display/panel/truly,nt36672e.yaml | 66 ++
drivers/gpu/drm/panel/Kconfig | 9 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-truly-nt36672e.c | 644 ++++++++++++++++++
4 files changed, 720 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
create mode 100644 drivers/gpu/drm/panel/panel-truly-nt36672e.c
--
2.17.1
Document Truly NT36672E FHD+ LCD DSI panel.
Signed-off-by: Ritesh Kumar <[email protected]>
---
.../display/panel/truly,nt36672e.yaml | 66 +++++++++++++++++++
1 file changed, 66 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
new file mode 100644
index 000000000000..39ab05c5b103
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/truly,nt36672e.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Truly NT36672E LCD DSI Panel
+
+maintainers:
+ - Ritesh Kumar <[email protected]>
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ const: truly,nt36672e
+
+ reg:
+ maxItems: 1
+ description: DSI virtual channel
+
+ vddi-supply: true
+ avdd-supply: true
+ avee-supply: true
+ port: true
+ reset-gpios: true
+ backlight: true
+
+additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - vddi-supply
+ - avdd-supply
+ - avee-supply
+ - reset-gpios
+ - port
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ panel@0 {
+ compatible = "truly,nt36672e";
+ reg = <0>;
+
+ reset-gpios = <&tlmm 44 GPIO_ACTIVE_HIGH>;
+
+ vddi-supply = <&vreg_l8c_1p8>;
+ avdd-supply = <&disp_avdd>;
+ avee-supply = <&disp_avee>;
+
+ backlight = <&pwm_backlight>;
+
+ port {
+ panel0_in: endpoint {
+ remote-endpoint = <&dsi0_out>;
+ };
+ };
+ };
+ };
+...
--
2.17.1
On 22/12/2023 12:07, Ritesh Kumar wrote:
> Document Truly NT36672E FHD+ LCD DSI panel.
>
> Signed-off-by: Ritesh Kumar <[email protected]>
> ---
> .../display/panel/truly,nt36672e.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
> new file mode 100644
> index 000000000000..39ab05c5b103
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/truly,nt36672e.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Truly NT36672E LCD DSI Panel
> +
> +maintainers:
> + - Ritesh Kumar <[email protected]>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: truly,nt36672e
Eee? This is existing Novatek, isn't it?
> +
> + reg:
> + maxItems: 1
> + description: DSI virtual channel
> +
> + vddi-supply: true
> + avdd-supply: true
> + avee-supply: true
> + port: true
> + reset-gpios: true
> + backlight: true
> +
> +additionalProperties: false
This goes after required:.
Best regards,
Krzysztof
On 22/12/2023 12:07, Ritesh Kumar wrote:
> Add support for the 1080x2408 Truly NT36672E LCD DSI mode panel
Google does not find anything for "Truly NT36672E", so I have some
doubts whether you used correct vendor name or product ID.
Best regards,
Krzysztof
Hi Krzysztof,
>-----Original Message-----
>From: Krzysztof Kozlowski <[email protected]>
>Sent: Friday, December 22, 2023 9:05 PM
>To: Ritesh Kumar (QUIC) <[email protected]>; dri-
>[email protected]; [email protected]; linux-
>[email protected]
>Cc: [email protected]; Jessica Zhang (QUIC)
><[email protected]>; [email protected];
>[email protected]; [email protected];
>[email protected]; [email protected]; [email protected];
>[email protected]; [email protected]; [email protected];
>Abhinav Kumar (QUIC) <[email protected]>; Rajeev Nandan (QUIC)
><[email protected]>; Vishnuvardhan Prodduturi (QUIC)
><[email protected]>
>Subject: Re: [v1 0/2] Add support for Truly NT36672E LCD DSI panel
>
>WARNING: This email originated from outside of Qualcomm. Please be wary of
>any links or attachments, and do not enable macros.
>
>On 22/12/2023 12:07, Ritesh Kumar wrote:
>> Add support for the 1080x2408 Truly NT36672E LCD DSI mode panel
>
>Google does not find anything for "Truly NT36672E", so I have some doubts
>whether you used correct vendor name or product ID.
Novatek is the DDIC vendor and Truly is the glass vendor. It should be "Novatek NT36672E". I was confused earlier between Truly and Novatek.
We don't have online link for the datasheet. We received it from panel vendor. This panel is being used on Qualcomm's multiple internal platforms.
I will rename Truly to Novatek in next version.
Thanks,
Ritesh
Hi Krzysztof,
>-----Original Message-----
>From: Krzysztof Kozlowski <[email protected]>
>Sent: Friday, December 22, 2023 9:02 PM
>To: Ritesh Kumar (QUIC) <[email protected]>; dri-
>[email protected]; [email protected]; linux-
>[email protected]
>Cc: [email protected]; Jessica Zhang (QUIC)
><[email protected]>; [email protected];
>[email protected]; [email protected];
>[email protected]; [email protected]; [email protected];
>[email protected]; [email protected]; [email protected];
>Abhinav Kumar (QUIC) <[email protected]>; Rajeev Nandan (QUIC)
><[email protected]>; Vishnuvardhan Prodduturi (QUIC)
><[email protected]>
>Subject: Re: [v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI
>panel
>
>WARNING: This email originated from outside of Qualcomm. Please be wary of
>any links or attachments, and do not enable macros.
>
>On 22/12/2023 12:07, Ritesh Kumar wrote:
>> Document Truly NT36672E FHD+ LCD DSI panel.
>>
>> Signed-off-by: Ritesh Kumar <[email protected]>
>> ---
>> .../display/panel/truly,nt36672e.yaml | 66 +++++++++++++++++++
>> 1 file changed, 66 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>> b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>> new file mode 100644
>> index 000000000000..39ab05c5b103
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.y
>> +++ aml
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/panel/truly,nt36672e.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Truly NT36672E LCD DSI Panel
>> +
>> +maintainers:
>> + - Ritesh Kumar <[email protected]>
>> +
>> +allOf:
>> + - $ref: panel-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: truly,nt36672e
>
>Eee? This is existing Novatek, isn't it?
This is novatek nt36672e panel. Existing novatek is nt36672a panel.
They differ in resolution, power on/off sequence (init sequence, delays), panel reset sequence.
NT36672E panel supports refresh rates of 60Hz, 90Hz, 120Hz and 144Hz. It also supports DSC.
To start with, I have added support for uncompressed 60Hz. In subsequent patches, other configurations
support will be added.
>
>> +
>> + reg:
>> + maxItems: 1
>> + description: DSI virtual channel
>> +
>> + vddi-supply: true
>> + avdd-supply: true
>> + avee-supply: true
>> + port: true
>> + reset-gpios: true
>> + backlight: true
>> +
>> +additionalProperties: false
>
>
>This goes after required:.
Thanks, will change in next version.
Thanks,
Ritesh