2015-07-25 09:49:23

by Incarnation P. Lee

Subject: [PATCH 1/5] staging: lustre: Add blank line after variable definition.

From: "Pan Li" <[email protected]>

Add blank line after local variable definition to make it clear for reading.
Signed-off-by: Pan Li <[email protected]>

---
drivers/staging/lustre/lustre/obdclass/cl_page.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c
index a7f3032..8b2c1e7 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_page.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c
@@ -169,6 +169,7 @@ int cl_page_gang_lookup(const struct lu_env *env, struct cl_object *obj,
while ((nr = radix_tree_gang_lookup(&hdr->coh_tree, (void **)pvec,
idx, CLT_PVEC_SIZE)) > 0) {
int end_of_region = 0;
+
idx = pvec[nr - 1]->cp_index + 1;
for (i = 0, j = 0; i < nr; ++i) {
page = pvec[i];
@@ -286,6 +287,7 @@ static struct cl_page *cl_page_alloc(const struct lu_env *env,
GFP_NOFS);
if (page != NULL) {
int result = 0;
+
atomic_set(&page->cp_ref, 1);
if (type == CPT_CACHEABLE) /* for radix tree */
atomic_inc(&page->cp_ref);
--
1.9.0

2015-07-31 22:53:04

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/5] staging: lustre: Add blank line after variable definition.

On Sat, Jul 25, 2015 at 09:49:00AM +0800, Incarnation P. Lee wrote:
> From: "Pan Li" <[email protected]>
>
> Add blank line after local variable definition to make it clear for reading.
> Signed-off-by: Pan Li <[email protected]>

Please put a blank line before your signed-off-by line, otherwise the
tools don't pick it up properly.

Please fix up and resend the series.

thanks,

greg k-h