2023-04-29 14:50:45

by Himanshu Bhavani

[permalink] [raw]
Subject: [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM

From 8756e66b7fba0a5063c6011983eb876456504ede Mon Sep 17 00:00:00 2001
From: Himanshu Bhavani <[email protected]>
Date: Sat, 29 Apr 2023 19:32:27 +0530
Subject: [PATCH] Add an entry in imx8mm boards for Emtop SOM-IMX8MM

Added an entry to the list of imx8mm boards denoting the Emtop SOM-IMX8MM

Signed-off-by: Himanshu Bhavani <[email protected]>

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 442ce8f4d675..61f3beabb1d0 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -902,6 +902,7 @@ properties:
- toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules
- variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-MX8MM module
- prt,prt8mm # i.MX8MM Protonic PRT8MM Board
+ - fsl,imx8mm-emtop # i.MX8MM Emtop SOM
- const: fsl,imx8mm

- description: Engicam i.Core MX8M Mini SoM based boards
--
2.25.1


2023-04-30 10:34:53

by Francesco Dolcini

[permalink] [raw]
Subject: Re: [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM

On Sat, Apr 29, 2023 at 02:07:51PM +0000, Himanshu Bhavani wrote:
> >From 8756e66b7fba0a5063c6011983eb876456504ede Mon Sep 17 00:00:00 2001
> From: Himanshu Bhavani <[email protected]>
> Date: Sat, 29 Apr 2023 19:32:27 +0530
> Subject: [PATCH] Add an entry in imx8mm boards for Emtop SOM-IMX8MM
These looks just broken

> Added an entry to the list of imx8mm boards denoting the Emtop SOM-IMX8MM
>
> Signed-off-by: Himanshu Bhavani <[email protected]>
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..61f3beabb1d0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -902,6 +902,7 @@ properties:
> - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules
> - variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-MX8MM module
> - prt,prt8mm # i.MX8MM Protonic PRT8MM Board
> + - fsl,imx8mm-emtop # i.MX8MM Emtop SOM
Wrong vendor? fsl is freescale AKA nxp, and this board is supposed to be
emtop.

Francesco

2023-04-30 12:14:05

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM

On 29/04/2023 16:07, Himanshu Bhavani wrote:
> From 8756e66b7fba0a5063c6011983eb876456504ede Mon Sep 17 00:00:00 2001
> From: Himanshu Bhavani <[email protected]>
> Date: Sat, 29 Apr 2023 19:32:27 +0530
> Subject: [PATCH] Add an entry in imx8mm boards for Emtop SOM-IMX8MM

Please fix your patch format.

Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).

>
> Added an entry to the list of imx8mm boards denoting the Emtop SOM-IMX8MM
>
> Signed-off-by: Himanshu Bhavani <[email protected]>
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..61f3beabb1d0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -902,6 +902,7 @@ properties:
> - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules
> - variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-MX8MM module
> - prt,prt8mm # i.MX8MM Protonic PRT8MM Board
> + - fsl,imx8mm-emtop # i.MX8MM Emtop SOM

Messed order, incorrect vendor prefix. Also board name looks actually
missing.

Best regards,
Krzysztof